From b389df0f6b5a2e0655e9f101af97d75e35fb874c Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Wed, 30 Apr 2025 11:03:46 +0300 Subject: [PATCH] drm/st7571-i2c: Fix IS_ERR() vs NULL checks in probe() The devm_kzalloc() function returns NULL on failure, not error pointers. Also printing an error message for kmalloc() failures is against kernel style so just return -ENOMEM without printing a message. (Kmalloc already prints a message). Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD controller") Signed-off-by: Dan Carpenter Reviewed-by: Javier Martinez Canillas Link: https://lore.kernel.org/r/aBHZYgPPPYY-J8Vd@stanley.mountain Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/st7571-i2c.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tiny/st7571-i2c.c b/drivers/gpu/drm/tiny/st7571-i2c.c index dc410ec41baf..eec846892962 100644 --- a/drivers/gpu/drm/tiny/st7571-i2c.c +++ b/drivers/gpu/drm/tiny/st7571-i2c.c @@ -908,16 +908,14 @@ static int st7571_probe(struct i2c_client *client) st7571->hwbuf = devm_kzalloc(&client->dev, (st7571->nlines * st7571->ncols * st7571->bpp) / 8, GFP_KERNEL); - if (IS_ERR(st7571->hwbuf)) - return dev_err_probe(&client->dev, PTR_ERR(st7571->hwbuf), - "Failed to allocate intermediate buffer\n"); + if (!st7571->hwbuf) + return -ENOMEM; st7571->row = devm_kzalloc(&client->dev, (st7571->ncols * st7571->bpp), GFP_KERNEL); - if (IS_ERR(st7571->row)) - return dev_err_probe(&client->dev, PTR_ERR(st7571->row), - "Failed to allocate row buffer\n"); + if (!st7571->row) + return -ENOMEM; ret = st7571_mode_config_init(st7571); if (ret) -- 2.25.1