From 8dfd3fe56467ceabaac39ea884e0dc882c1832cd Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Wed, 4 Nov 2015 18:55:15 +0100 Subject: [PATCH] greybus: es1: separate urb allocation and submission Separate in-urb allocation and submission. This is needed for the driver-model rework. Compile-tested only. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/es1.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/es1.c b/drivers/staging/greybus/es1.c index 23860870d4f1..57247712ce60 100644 --- a/drivers/staging/greybus/es1.c +++ b/drivers/staging/greybus/es1.c @@ -650,7 +650,7 @@ static int ap_probe(struct usb_interface *interface, goto error; } - /* Allocate buffers for our cport in messages and start them up */ + /* Allocate buffers for our cport in messages */ for (i = 0; i < NUM_CPORT_IN_URB; ++i) { struct urb *urb; u8 *buffer; @@ -668,9 +668,6 @@ static int ap_probe(struct usb_interface *interface, cport_in_callback, hd); es1->cport_in_urb[i] = urb; es1->cport_in_buffer[i] = buffer; - retval = usb_submit_urb(urb, GFP_KERNEL); - if (retval) - goto error; } /* Allocate urbs for our CPort OUT messages */ @@ -689,6 +686,13 @@ static int ap_probe(struct usb_interface *interface, (S_IWUSR | S_IRUGO), gb_debugfs_get(), es1, &apb1_log_enable_fops); + + for (i = 0; i < NUM_CPORT_IN_URB; ++i) { + retval = usb_submit_urb(es1->cport_in_urb[i], GFP_KERNEL); + if (retval) + goto error; + } + return 0; error: ap_disconnect(interface); -- 2.25.1