From 7efcce04309260e8088e89ca2c0a33cff452ac5c Mon Sep 17 00:00:00 2001 From: Sergio Paracuellos Date: Fri, 25 May 2018 18:54:50 +0200 Subject: [PATCH] staging: mt7621-gpio: avoid locking in mediatek_gpio_get_direction mediatek_gpio_get_direction function is holding across a simple read which it seems to be not neccessary at all. Just remove this locking cleaning code of this function a bit. Signed-off-by: Sergio Paracuellos Reviewed-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c index 79452eb7a654..143268a866c2 100644 --- a/drivers/staging/mt7621-gpio/gpio-mt7621.c +++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c @@ -129,12 +129,7 @@ static int mediatek_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) { struct mtk_gc *rg = to_mediatek_gpio(chip); - unsigned long flags; - u32 t; - - spin_lock_irqsave(&rg->lock, flags); - t = mtk_gpio_r32(rg, GPIO_REG_CTRL); - spin_unlock_irqrestore(&rg->lock, flags); + u32 t = mtk_gpio_r32(rg, GPIO_REG_CTRL); return (t & BIT(offset)) ? 0 : 1; } -- 2.25.1