From 79056b3fe8878fa77ea8e9cbe062e428d2845982 Mon Sep 17 00:00:00 2001 From: Namhyung Kim Date: Thu, 27 Feb 2025 11:12:22 -0800 Subject: [PATCH] perf ftrace: Remove an unnecessary condition check in BPF The bucket_num is set based on the {max,min}_latency already in cmd_ftrace(), so no need to check it again in BPF. Also I found that it didn't pass the max_latency to BPF. :) No functional changes intended. Cc: Gabriele Monaco Link: https://lore.kernel.org/r/20250227191223.1288473-2-namhyung@kernel.org Signed-off-by: Namhyung Kim --- tools/perf/util/bpf_skel/func_latency.bpf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/bpf_skel/func_latency.bpf.c b/tools/perf/util/bpf_skel/func_latency.bpf.c index 3d3d9f427c20..ad7054744678 100644 --- a/tools/perf/util/bpf_skel/func_latency.bpf.c +++ b/tools/perf/util/bpf_skel/func_latency.bpf.c @@ -125,8 +125,7 @@ int BPF_PROG(func_end) // than the min latency desired. if (val > 0) { // 1st entry: [ 1 unit .. bucket_range units ) key = val / bucket_range + 1; - if (key >= bucket_num || - val >= max_latency - min_latency) + if (key >= bucket_num) key = bucket_num - 1; } -- 2.25.1