From 6adc5af50a5401a19c1f23b3ed2ebfd3a0d8cdc6 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Sat, 21 Dec 2024 02:55:03 -0500 Subject: [PATCH] bcachefs: btree_path_very_locks(): verify lock seq If the btree_path's lock seq is wrong, the next bch2_trans_relock() operation is guaranteed to fail and we take an unnecessary transaction restart. Signed-off-by: Kent Overstreet --- fs/bcachefs/btree_locking.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/bcachefs/btree_locking.c b/fs/bcachefs/btree_locking.c index d343df9f0ad2..b339c209345a 100644 --- a/fs/bcachefs/btree_locking.c +++ b/fs/bcachefs/btree_locking.c @@ -856,6 +856,9 @@ void bch2_btree_path_verify_locks(struct btree_path *path) (want == BTREE_NODE_UNLOCKED || have != BTREE_NODE_WRITE_LOCKED) && want != have); + + BUG_ON(btree_node_locked(path, l) && + path->l[l].lock_seq != six_lock_seq(&path->l[l].b->c.lock)); } } -- 2.25.1