From 4b9953fa714442d8b06348fd618eb8214181d3f1 Mon Sep 17 00:00:00 2001 From: Ankit Kumar Date: Fri, 14 Feb 2025 22:51:00 +0530 Subject: [PATCH] init: write sequence behavior change for verify_only mode Change the behavior for verify_only mode to not disable verify_write_sequence unless its explicitly enabled. Update the fio doc. accordingly. Signed-off-by: Ankit Kumar --- HOWTO.rst | 3 ++- fio.1 | 3 ++- init.c | 6 ++++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/HOWTO.rst b/HOWTO.rst index 62537b65..d725960e 100644 --- a/HOWTO.rst +++ b/HOWTO.rst @@ -3818,7 +3818,8 @@ Verification invocation of this workload. This option allows one to check data multiple times at a later date without overwriting it. This option makes sense only for workloads that write data, and does not support workloads with the - :option:`time_based` option set. + :option:`time_based` option set. :option:`verify_write_sequence` will be + disabled in this mode, unless its explicitly enabled. .. option:: do_verify=bool diff --git a/fio.1 b/fio.1 index 1581797a..d9412fd9 100644 --- a/fio.1 +++ b/fio.1 @@ -3544,7 +3544,8 @@ Do not perform specified workload, only verify data still matches previous invocation of this workload. This option allows one to check data multiple times at a later date without overwriting it. This option makes sense only for workloads that write data, and does not support workloads with the -\fBtime_based\fR option set. +\fBtime_based\fR option set. \fBverify_write_sequence\fR option will be +disabled in this mode, unless its explicitly enabled. .TP .BI do_verify \fR=\fPbool Run the verify phase after a write phase. Only valid if \fBverify\fR is diff --git a/init.c b/init.c index 96a03d98..dc3e7ed1 100644 --- a/init.c +++ b/init.c @@ -854,8 +854,10 @@ static int fixup_options(struct thread_data *td) o->verify_interval = gcd(o->min_bs[DDIR_WRITE], o->max_bs[DDIR_WRITE]); - if (td->o.verify_only) - o->verify_write_sequence = 0; + if (o->verify_only) { + if (!fio_option_is_set(o, verify_write_sequence)) + o->verify_write_sequence = 0; + } } if (td->o.oatomic) { -- 2.25.1