From 4655560d8137469cff0bbe30b01cca6df1b079b2 Mon Sep 17 00:00:00 2001 From: Vincent Fu Date: Thu, 22 May 2025 17:53:41 +0000 Subject: [PATCH] t/verify: skip crc7 when running checksum tests The crc7 checksum has a 1/128 chance of not detecting data corruption when we mangle data written to the device. Skip these tests when testing the checksum functions to avoid false test failures. Signed-off-by: Vincent Fu --- t/verify.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/t/verify.py b/t/verify.py index 58bf327d..4c3d0a3c 100755 --- a/t/verify.py +++ b/t/verify.py @@ -627,7 +627,13 @@ def verify_test_csum(test_env, args, mbs, csum): methods can reliably detect data integrity issues. """ for test in TEST_LIST_CSUM: - test['force_skip'] = False + # The crc7 checksum will produce too many false positives since when we + # modify the data there is a 1/128 chance that the checksum will not + # change. So skip this set of tests. + if csum == 'crc7': + test['force_skip'] = True + else: + test['force_skip'] = False test['fio_opts']['verify'] = csum if csum in ('pattern', 'pattern_hdr'): -- 2.25.1