From 4316f6409721bc42e878df1057de0e4be7df3d44 Mon Sep 17 00:00:00 2001 From: Alexey Dobriyan Date: Mon, 22 Feb 2021 16:21:22 +0300 Subject: [PATCH] zbd: simplify zoneskip= validness check Simply check the remainder: (zoneskip % zone_size) > 0 It will do the right thing for all zoneskip= values, and zone size being positive is checked earlier. Reviewed-by: Dmitry Fomichev Signed-off-by: Alexey Dobriyan (SK hynix) Signed-off-by: Jens Axboe --- zbd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/zbd.c b/zbd.c index 6a26fe10..a93a977e 100644 --- a/zbd.c +++ b/zbd.c @@ -285,9 +285,7 @@ static bool zbd_verify_sizes(void) return false; } - if (td->o.zone_skip && - (td->o.zone_skip < td->o.zone_size || - td->o.zone_skip % td->o.zone_size)) { + if (td->o.zone_skip % td->o.zone_size) { log_err("%s: zoneskip %llu is not a multiple of the device zone size %llu.\n", f->file_name, (unsigned long long) td->o.zone_skip, (unsigned long long) td->o.zone_size); -- 2.25.1