From 2f2e6c23e26888acb7ad2f2a2e4bd8fa5b250c0f Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Fri, 19 Dec 2014 08:04:48 -0700 Subject: [PATCH] options: turn missing options into debug parse messages It's not an error, we expect it to happen if we try and check for set options that aren't available (due to being platform specific, libraries missing, etc). This fixes cases where fio would spew: fio: no option found at offset 1240 and other offsets. Signed-off-by: Jens Axboe --- options.c | 4 +--- options.h | 6 ++++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/options.c b/options.c index 6ceefbc1..e3c9c87b 100644 --- a/options.c +++ b/options.c @@ -4204,10 +4204,8 @@ int __fio_option_is_set(struct thread_options *o, unsigned int off1) } } - if (!opt) { - log_err("fio: no option found at offset %u\n", off1); + if (!opt) return -1; - } opt_off = opt - &fio_options[0]; index = opt_off / (8 * sizeof(uint64_t)); diff --git a/options.h b/options.h index e8308846..36fd35d2 100644 --- a/options.h +++ b/options.h @@ -26,9 +26,11 @@ extern int __fio_option_is_set(struct thread_options *, unsigned int off); #define fio_option_is_set(__td, name) \ ({ \ - int __r = __fio_option_is_set((__td), td_var_offset(name)); \ + const unsigned int off = td_var_offset(name); \ + int __r = __fio_option_is_set((__td), off); \ if (__r == -1) { \ - log_err("fio: wanted %s\n", __fio_stringify(name)); \ + dprint(FD_PARSE, "option %s/%u not found in map\n", \ + __fio_stringify(name), off); \ __r = 0; \ } \ __r; \ -- 2.25.1