From 0905f371046906353108ded80b1564f8188ce85e Mon Sep 17 00:00:00 2001 From: Vitaly Chikunov Date: Tue, 24 Oct 2023 05:29:40 +0300 Subject: [PATCH] nfs: Fix incorrect engine registering for '--enghelp' list `ioengine` from `nfs` (internal) engine is incorrectly exported thus overriding its value in constructor callbacks of other external engines, that are used for registering engine for listing with `--enghelp`. Because flist is unsafe to double adding it also making `engine_list` to become corrupt and causing infinite loop or abnormal list termination when printing engine list. Issue: https://github.com/axboe/fio/issues/1655 Fixes: 9326926b ("NFS engine") Signed-off-by: Vitaly Chikunov --- engines/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engines/nfs.c b/engines/nfs.c index 970962a3..ce748d14 100644 --- a/engines/nfs.c +++ b/engines/nfs.c @@ -308,7 +308,7 @@ static int fio_libnfs_close(struct thread_data *td, struct fio_file *f) return ret; } -struct ioengine_ops ioengine = { +static struct ioengine_ops ioengine = { .name = "nfs", .version = FIO_IOOPS_VERSION, .setup = fio_libnfs_setup, -- 2.25.1