From 06c40418f97811092c0aece1760487400bcdd506 Mon Sep 17 00:00:00 2001 From: Vincent Fu Date: Thu, 28 Dec 2023 22:12:47 -0500 Subject: [PATCH] t/strided: check_result() has no return value check_result() erroneously returned True or False. Drop the return value to be consistent with the parent and related classes. Signed-off-by: Vincent Fu --- t/strided.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/t/strided.py b/t/strided.py index b8396aef..75c429e4 100755 --- a/t/strided.py +++ b/t/strided.py @@ -99,7 +99,7 @@ class StridedTest(FioJobCmdTest): offset = int(tokens[4]) if offset < zonestart or offset >= zonestart + self.fio_opts['zonerange']: print(f"Offset {offset} outside of zone starting at {zonestart}") - return False + return # skip next section if norandommap is enabled with no # random_generator or with a random_generator != lfsr @@ -117,17 +117,15 @@ class StridedTest(FioJobCmdTest): block = (offset - zonestart) / self.fio_opts['bs'] if block in zoneset: print(f"Offset {offset} in zone already touched") - return False + return zoneset.add(block) if iosperzone % iosperrange == 0: if len(zoneset) != iosperrange: print(f"Expected {iosperrange} blocks in zone but only saw {len(zoneset)}") - return False + return zoneset = set() - return True - TEST_LIST = [ # randommap enabled { -- 2.25.1