From 061a0773e910417aeca7b95b12248489d29aea84 Mon Sep 17 00:00:00 2001 From: Vincent Fu Date: Sat, 25 Jul 2020 13:20:33 -0400 Subject: [PATCH] t/run-fio-tests: fix issues identified by pylint3 and pyflakes3 - fix whitespace issue in function parameter list - eliminate extra 'requirements' key for t0012 - t0013 does not need a separate test class - specify string format arguments as logging function parameters --- t/run-fio-tests.py | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/t/run-fio-tests.py b/t/run-fio-tests.py index 7e4120f4..6aae8fa1 100755 --- a/t/run-fio-tests.py +++ b/t/run-fio-tests.py @@ -447,13 +447,6 @@ class FioJobTest_iops_rate(FioJobTest): self.passed = False -class FioJobTest_t0013(FioJobTest): - """Runs fio test job t0013""" - - def check_result(self): - super(FioJobTest_t0013, self).check_result() - - class Requirements(object): """Requirements consists of multiple run environment characteristics. These are to determine if a particular test can be run""" @@ -693,13 +686,13 @@ TEST_LIST = [ 'pre_job': None, 'pre_success': None, 'output_format': 'json', - 'requirements': [], 'requirements': [Requirements.not_macos], # mac os does not support CPU affinity + # which is required for gtod offloading }, { 'test_id': 13, - 'test_class': FioJobTest_t0013, + 'test_class': FioJobTest, 'job': 't0013.fio', 'success': SUCCESS_DEFAULT, 'pre_job': None, @@ -849,9 +842,9 @@ def main(): print("Invalid --pass-through argument '%s'" % arg) print("Syntax for --pass-through is TESTNUMBER:ARGUMENT") return - split = arg.split(":",1) + split = arg.split(":", 1) pass_through[int(split[0])] = split[1] - logging.debug("Pass-through arguments: %s" % pass_through) + logging.debug("Pass-through arguments: %s", pass_through) if args.fio_root: fio_root = args.fio_root -- 2.25.1