From 01efebd8f13c41341754a2f0b431aa81209f8f30 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Thu, 26 Jan 2023 13:36:30 -0500 Subject: [PATCH] bcachefs: Add an assert to bch2_bucket_nocow_unlock() Signed-off-by: Kent Overstreet --- fs/bcachefs/nocow_locking.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/bcachefs/nocow_locking.c b/fs/bcachefs/nocow_locking.c index 53e5bc9fd585..396357cd8f2f 100644 --- a/fs/bcachefs/nocow_locking.c +++ b/fs/bcachefs/nocow_locking.c @@ -18,6 +18,8 @@ bool bch2_bucket_nocow_is_locked(struct bucket_nocow_lock_table *t, struct bpos return false; } +#define sign(v) (v < 0 ? -1 : v > 0 ? 1 : 0) + void bch2_bucket_nocow_unlock(struct bucket_nocow_lock_table *t, struct bpos bucket, int flags) { u64 dev_bucket = bucket_to_u64(bucket); @@ -27,6 +29,8 @@ void bch2_bucket_nocow_unlock(struct bucket_nocow_lock_table *t, struct bpos buc for (i = 0; i < ARRAY_SIZE(l->b); i++) if (l->b[i] == dev_bucket) { + BUG_ON(sign(atomic_read(&l->l[i])) != lock_val); + if (!atomic_sub_return(lock_val, &l->l[i])) closure_wake_up(&l->wait); return; -- 2.25.1