From bbd6f1bb6e3b1646448a69f607c07360355ac5b8 Mon Sep 17 00:00:00 2001 From: Shin'ichiro Kawasaki Date: Wed, 15 Jul 2020 13:13:16 +0900 Subject: [PATCH] t/zbd: Fix pass condition of test case #3 The test case #3 checks that the read workload for empty zones ends without reading any data. When zonemode=zbd, it is expected for both regular block devices and zoned block devices. However, the test case allowed for regular block devices to read data from empty zones. Remove this special pass condition for regular block devices. Reviewed-by: Damien Le Moal Signed-off-by: Shin'ichiro Kawasaki Signed-off-by: Jens Axboe --- t/zbd/test-zbd-support | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support index 4001be3b..1178afd4 100755 --- a/t/zbd/test-zbd-support +++ b/t/zbd/test-zbd-support @@ -170,13 +170,7 @@ test3() { opts+=("--zonesize=${zone_size}") fi run_fio "${opts[@]}" >> "${logfile}.${test_number}" 2>&1 || return $? - grep -q 'READ:' "${logfile}.${test_number}" - rc=$? - if [ -n "$is_zbd" ]; then - [ $rc != 0 ] - else - [ $rc = 0 ] - fi + ! grep -q 'READ:' "${logfile}.${test_number}" } # Run fio with --read_beyond_wp=1 against an empty zone. -- 2.25.1