From cd041bf495808e857e5ae08d86064374f1dca425 Mon Sep 17 00:00:00 2001 From: Erwan Velu Date: Wed, 16 Dec 2020 21:42:36 +0100 Subject: [PATCH] examples: Clarify time_based usage When reading examples, many jobs assign a value to time_based. It could even very misleading as some put the same value as for the runtime. No value is expected, so let's have all examples using the same syntax. Signed-off-by: Erwan Velu --- examples/cpp_null.fio | 2 +- examples/dev-dax.fio | 2 +- examples/e4defrag.fio | 2 +- examples/e4defrag2.fio | 5 ++--- examples/falloc.fio | 4 ++-- examples/fio-rand-RW.fio | 2 +- examples/fio-rand-read.fio | 2 +- examples/fio-rand-write.fio | 2 +- examples/fio-seq-RW.fio | 2 +- examples/fio-seq-read.fio | 2 +- examples/fio-seq-write.fio | 2 +- examples/libpmem.fio | 2 +- examples/libzbc-rand-write.fio | 2 +- examples/null.fio | 1 - examples/pmemblk.fio | 2 +- examples/zbd-rand-write.fio | 2 +- 16 files changed, 17 insertions(+), 19 deletions(-) diff --git a/examples/cpp_null.fio b/examples/cpp_null.fio index 436ed90a..7c62beaf 100644 --- a/examples/cpp_null.fio +++ b/examples/cpp_null.fio @@ -7,4 +7,4 @@ ioengine=cpp_null size=100g rw=randread norandommap -time_based=0 +time_based diff --git a/examples/dev-dax.fio b/examples/dev-dax.fio index d9f430eb..f89c4c6a 100644 --- a/examples/dev-dax.fio +++ b/examples/dev-dax.fio @@ -2,7 +2,7 @@ bs=2m ioengine=dev-dax norandommap -time_based=1 +time_based runtime=30 group_reporting disable_lat=1 diff --git a/examples/e4defrag.fio b/examples/e4defrag.fio index cb94e85a..d6495f7a 100644 --- a/examples/e4defrag.fio +++ b/examples/e4defrag.fio @@ -18,7 +18,7 @@ rw=write # Run e4defrag and aio-dio workers in parallel [e4defrag] stonewall -time_based=30 +time_based runtime=30 ioengine=e4defrag buffered=0 diff --git a/examples/e4defrag2.fio b/examples/e4defrag2.fio index c6485997..2d4e1a87 100644 --- a/examples/e4defrag2.fio +++ b/examples/e4defrag2.fio @@ -55,7 +55,7 @@ inplace=1 bs=4k donorname=file3.def filename=file3 -time_based=30 +time_based rw=randwrite [buffered-aio-32k] @@ -68,7 +68,7 @@ bs=32k filename=file3 rw=randrw runtime=30 -time_based=30 +time_based numjobs=4 [direct-aio-32k] @@ -82,7 +82,6 @@ bs=32k filename=file3 rw=randrw runtime=30 -time_based=30 numjobs=4 diff --git a/examples/falloc.fio b/examples/falloc.fio index fa307314..fadf1321 100644 --- a/examples/falloc.fio +++ b/examples/falloc.fio @@ -15,7 +15,7 @@ group_reporting [falloc-fuzzer] stonewall runtime=10 -time_based=10 +time_based bssplit=4k/10:64k/50:32k/40 rw=randwrite numjobs=1 @@ -24,7 +24,7 @@ filename=fragmented_file [punch hole-fuzzer] bs=4k runtime=10 -time_based=10 +time_based rw=randtrim numjobs=2 filename=fragmented_file diff --git a/examples/fio-rand-RW.fio b/examples/fio-rand-RW.fio index 0df0bc17..a1074a1a 100644 --- a/examples/fio-rand-RW.fio +++ b/examples/fio-rand-RW.fio @@ -9,7 +9,7 @@ rwmixwrite=40 bs=4K direct=0 numjobs=4 -time_based=1 +time_based runtime=900 [file1] diff --git a/examples/fio-rand-read.fio b/examples/fio-rand-read.fio index bc154668..319a9209 100644 --- a/examples/fio-rand-read.fio +++ b/examples/fio-rand-read.fio @@ -7,7 +7,7 @@ rw=randread bs=4K direct=0 numjobs=1 -time_based=1 +time_based runtime=900 [file1] diff --git a/examples/fio-rand-write.fio b/examples/fio-rand-write.fio index bd1b73a9..55ededbd 100644 --- a/examples/fio-rand-write.fio +++ b/examples/fio-rand-write.fio @@ -7,7 +7,7 @@ rw=randwrite bs=4K direct=0 numjobs=4 -time_based=1 +time_based runtime=900 [file1] diff --git a/examples/fio-seq-RW.fio b/examples/fio-seq-RW.fio index 8f7090f3..89e5c679 100644 --- a/examples/fio-seq-RW.fio +++ b/examples/fio-seq-RW.fio @@ -9,7 +9,7 @@ rwmixwrite=40 bs=256K direct=0 numjobs=4 -time_based=1 +time_based runtime=900 [file1] diff --git a/examples/fio-seq-read.fio b/examples/fio-seq-read.fio index 28de93c8..2b272480 100644 --- a/examples/fio-seq-read.fio +++ b/examples/fio-seq-read.fio @@ -5,7 +5,7 @@ rw=read bs=256K direct=1 numjobs=1 -time_based=1 +time_based runtime=900 [file1] diff --git a/examples/fio-seq-write.fio b/examples/fio-seq-write.fio index b291a15a..ac6c9eef 100644 --- a/examples/fio-seq-write.fio +++ b/examples/fio-seq-write.fio @@ -7,7 +7,7 @@ rw=write bs=256K direct=0 numjobs=1 -time_based=1 +time_based runtime=900 [file1] diff --git a/examples/libpmem.fio b/examples/libpmem.fio index 65b1d687..25392bbc 100644 --- a/examples/libpmem.fio +++ b/examples/libpmem.fio @@ -3,7 +3,7 @@ bs=4k size=8g ioengine=libpmem norandommap -time_based=1 +time_based group_reporting invalidate=1 disable_lat=1 diff --git a/examples/libzbc-rand-write.fio b/examples/libzbc-rand-write.fio index ce5870e4..41496219 100644 --- a/examples/libzbc-rand-write.fio +++ b/examples/libzbc-rand-write.fio @@ -12,7 +12,7 @@ max_open_zones=32 bs=512K direct=1 numjobs=16 -time_based=1 +time_based runtime=300 [dev1] diff --git a/examples/null.fio b/examples/null.fio index 9d2f3e00..4534cbdd 100644 --- a/examples/null.fio +++ b/examples/null.fio @@ -7,4 +7,3 @@ ioengine=null size=100g rw=randread norandommap -time_based=0 diff --git a/examples/pmemblk.fio b/examples/pmemblk.fio index 2d5ecfce..0606ca89 100644 --- a/examples/pmemblk.fio +++ b/examples/pmemblk.fio @@ -2,7 +2,7 @@ bs=1m ioengine=pmemblk norandommap -time_based=1 +time_based runtime=30 group_reporting disable_lat=1 diff --git a/examples/zbd-rand-write.fio b/examples/zbd-rand-write.fio index 1b3f2088..46cddd06 100644 --- a/examples/zbd-rand-write.fio +++ b/examples/zbd-rand-write.fio @@ -12,7 +12,7 @@ max_open_zones=32 bs=512K direct=1 numjobs=16 -time_based=1 +time_based runtime=180 [dev1] -- 2.25.1