From b423c4b0ebd539338bdce1babc0cf4c3f3e5d513 Mon Sep 17 00:00:00 2001 From: Aravind Ramesh Date: Wed, 27 Jan 2021 13:19:21 +0900 Subject: [PATCH] zbd: initialize sectors with data at start time Based on the flag enable_check_swd, which is false by default, fio does not initialize the swd value at startup, initializing the swd value to be zero, even if some zones have sectors with data. This can result in fio reflecting less than actual swd after a few writes are completed. In workloads where verify is enabled, fio resets all the zones and while resetting, it decrements the swd counter with the actual number of swds in that zone(swd-count - swd-in-zone), since swd-count is initialized to 0, it results in overflow of the variable causing unpredictable issues. So, initialize the swd to the correct value. Fixes: 409a4f291e7f ("zbd: avoid initializing swd when unnecessary") Signed-off-by: Aravind Ramesh Signed-off-by: Dmitry Fomichev Reviewed-by: Shin'ichiro Kawasaki Signed-off-by: Jens Axboe --- zbd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/zbd.c b/zbd.c index cf2abc3e..84165ddc 100644 --- a/zbd.c +++ b/zbd.c @@ -946,9 +946,6 @@ static void zbd_init_swd(struct fio_file *f) { uint64_t swd; - if (!enable_check_swd) - return; - swd = zbd_process_swd(f, SET_SWD); dprint(FD_ZBD, "%s(%s): swd = %" PRIu64 "\n", __func__, f->file_name, swd); -- 2.25.1