net: core: synchronize link-watch when carrier is queried
authorJohannes Berg <johannes.berg@intel.com>
Mon, 4 Dec 2023 20:47:07 +0000 (21:47 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 Dec 2023 04:16:45 +0000 (20:16 -0800)
commitfacd15dfd69122042502d99ab8c9f888b48ee994
tree1e84133ba27f60f62134588c7cce46dc73badc31
parentfaf4cf7495431d396147d5c73a84ccfddc458c9d
net: core: synchronize link-watch when carrier is queried

There are multiple ways to query for the carrier state: through
rtnetlink, sysfs, and (possibly) ethtool. Synchronize linkwatch
work before these operations so that we don't have a situation
where userspace queries the carrier state between the driver's
carrier off->on transition and linkwatch running and expects it
to work, when really (at least) TX cannot work until linkwatch
has run.

I previously posted a longer explanation of how this applies to
wireless [1] but with this wireless can simply query the state
before sending data, to ensure the kernel is ready for it.

[1] https://lore.kernel.org/all/346b21d87c69f817ea3c37caceb34f1f56255884.camel@sipsolutions.net/

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20231204214706.303c62768415.I1caedccae72ee5a45c9085c5eb49c145ce1c0dd5@changeid
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/netdevice.h
net/core/dev.c
net/core/dev.h
net/core/link_watch.c
net/core/net-sysfs.c
net/core/rtnetlink.c
net/ethtool/ioctl.c