dm-verity: restart or panic on an I/O error
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 24 Sep 2024 13:18:29 +0000 (15:18 +0200)
committerMikulas Patocka <mpatocka@redhat.com>
Thu, 26 Sep 2024 15:27:07 +0000 (17:27 +0200)
commite6a3531dd542cb127c8de32ab1e54a48ae19962b
treee004259683ef90628d2b2a01eee7fc2364c1e5ed
parent0a92e5cdeef9fa4cba8bef6cd1d91cff6b5d300b
dm-verity: restart or panic on an I/O error

Maxim Suhanov reported that dm-verity doesn't crash if an I/O error
happens. In theory, this could be used to subvert security, because an
attacker can create sectors that return error with the Write Uncorrectable
command. Some programs may misbehave if they have to deal with EIO.

This commit fixes dm-verity, so that if "panic_on_corruption" or
"restart_on_corruption" was specified and an I/O error happens, the
machine will panic or restart.

This commit also changes kernel_restart to emergency_restart -
kernel_restart calls reboot notifiers and these reboot notifiers may wait
for the bio that failed. emergency_restart doesn't call the notifiers.

Reported-by: Maxim Suhanov <dfirblog@gmail.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-verity-target.c