usb: typec: fix potential array underflow in ucsi_ccg_sync_control()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 11 Nov 2024 11:08:06 +0000 (14:08 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Nov 2024 11:54:01 +0000 (12:54 +0100)
commite56aac6e5a25630645607b6856d4b2a17b2311a5
tree91df3037d136ad84d3371f1791f3f0b8ad0b0262
parent2481af79671a6603fce201cbbc48f31e488e9fae
usb: typec: fix potential array underflow in ucsi_ccg_sync_control()

The "command" variable can be controlled by the user via debugfs.  The
worry is that if con_index is zero then "&uc->ucsi->connector[con_index
- 1]" would be an array underflow.

Fixes: 170a6726d0e2 ("usb: typec: ucsi: add support for separate DP altmode devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/c69ef0b3-61b0-4dde-98dd-97b97f81d912@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/ucsi/ucsi_ccg.c