block: remove the error argument to the block_bio_complete tracepoint
authorChristoph Hellwig <hch@lst.de>
Wed, 3 Jun 2020 05:14:43 +0000 (07:14 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 5 Jun 2020 03:16:11 +0000 (21:16 -0600)
commitd24de76af836260a99ca2ba281a937bd5bc55591
tree3e0982ad803e59fa210695684cfd58820cf9f86d
parent6ac92fb5cdff6e5708199f1d5d9d58011ccc76a0
block: remove the error argument to the block_bio_complete tracepoint

The status can be trivially derived from the bio itself.  That also avoid
callers like NVMe to incorrectly pass a blk_status_t instead of the errno,
and the overhead of translating the blk_status_t to the errno in the I/O
completion fast path when no tracing is enabled.

Fixes: 35fe0d12c8a3 ("nvme: trace bio completion")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c
drivers/nvme/host/nvme.h
include/trace/events/block.h
kernel/trace/blktrace.c