net: geneve: modify IP header check in geneve6_xmit_skb and geneve_xmit_skb
authorPhillip Potter <phil@philpotter.co.uk>
Thu, 22 Apr 2021 23:49:45 +0000 (00:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Apr 2021 20:19:18 +0000 (13:19 -0700)
commitd13f048dd40e8577260cd43faea8ec9b77520197
tree12c1c7bbe70c9c249c1e418e6d034d8f75d94968
parent7d742b509dd773f6ae2f32ffe3d2c0f3ea598a6d
net: geneve: modify IP header check in geneve6_xmit_skb and geneve_xmit_skb

Modify the header size check in geneve6_xmit_skb and geneve_xmit_skb
to use pskb_inet_may_pull rather than pskb_network_may_pull. This fixes
two kernel selftest failures introduced by the commit introducing the
checks:
IPv4 over geneve6: PMTU exceptions
IPv4 over geneve6: PMTU exceptions - nexthop objects

It does this by correctly accounting for the fact that IPv4 packets may
transit over geneve IPv6 tunnels (and vice versa), and still fixes the
uninit-value bug fixed by the original commit.

Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: 6628ddfec758 ("net: geneve: check skb is large enough for IPv4/IPv6 header")
Suggested-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/geneve.c