drm/xe/svm: Fix a potential bo UAF
authorThomas Hellström <thomas.hellstrom@linux.intel.com>
Wed, 26 Mar 2025 08:05:48 +0000 (09:05 +0100)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Thu, 27 Mar 2025 10:49:58 +0000 (11:49 +0100)
commitc9db07cab766b665c8fa1184649cef452f448dc8
tree0e2a142e2bf7e0b9f8554f3a7f04eb2c955b1961
parent6c55404d4f7306889eca9c333066bb4bdc2a4a7c
drm/xe/svm: Fix a potential bo UAF

If drm_gpusvm_migrate_to_devmem() succeeds, if a cpu access happens to the
range the bo may be freed before xe_bo_unlock(), causing a UAF.

Since the reference is transferred, use xe_svm_devmem_release() to
release the reference on drm_gpusvm_migrate_to_devmem() failure,
and hold a local reference to protect the UAF.

Fixes: 2f118c949160 ("drm/xe: Add SVM VRAM migration")
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20250326080551.40201-3-thomas.hellstrom@linux.intel.com
drivers/gpu/drm/xe/xe_svm.c