drm/xe: get rid of MAX_BINDS
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Thu, 15 Feb 2024 00:53:53 +0000 (16:53 -0800)
committerMatthew Brost <matthew.brost@intel.com>
Mon, 26 Feb 2024 20:12:22 +0000 (12:12 -0800)
commitba6bbdc6eaef92998ec7f323c9e1211d344d2556
tree5cba9bdaa781c2f78e01963a4a5f996ccbf89512
parent35ed1d2bfff7b1969e7f99f3641a83ea54f037e2
drm/xe: get rid of MAX_BINDS

Mesa has been issuing a single bind operation per ioctl since xe.ko
changed to GPUVA due xe.ko bug #746. If I change Mesa to try again to
issue every single bind operation it can in the same ioctl, it hits
the MAX_BINDS assertion when running Vulkan conformance tests.

Test dEQP-VK.sparse_resources.transfer_queue.3d.rgba32i.1024_128_8
issues 960 bind operations in a single ioctl, it's the most I could
find in the conformance suite.

I don't see a reason to keep the MAX_BINDS restriction: it doesn't
seem to be preventing any specific issue. If the number is too big for
the memory allocations, then those will fail. Nothing related to
num_binds seems to be using the stack. Let's just get rid of it.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Testcase: dEQP-VK.sparse_resources.transfer_queue.3d.rgba32i.1024_128_8
References: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/746
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240215005353.1295420-1-paulo.r.zanoni@intel.com
drivers/gpu/drm/xe/xe_vm.c