btrfs: qgroup: do not check qgroup inherit if qgroup is disabled
authorQu Wenruo <wqu@suse.com>
Sat, 20 Apr 2024 07:50:27 +0000 (17:20 +0930)
committerDavid Sterba <dsterba@suse.com>
Thu, 2 May 2024 19:30:14 +0000 (21:30 +0200)
commitb5357cb268c41b4e2b7383d2759fc562f5b58c33
tree727f1d049614df25245f9648061f66de6fca5f1f
parent63a6ce5a1a6261e4c70bad2b55c4e0de8da4762e
btrfs: qgroup: do not check qgroup inherit if qgroup is disabled

[BUG]
After kernel commit 86211eea8ae1 ("btrfs: qgroup: validate
btrfs_qgroup_inherit parameter"), user space tool snapper will fail to
create snapshot using its timeline feature.

[CAUSE]
It turns out that, if using timeline snapper would unconditionally pass
btrfs_qgroup_inherit parameter (assigning the new snapshot to qgroup 1/0)
for snapshot creation.

In that case, since qgroup is disabled there would be no qgroup 1/0, and
btrfs_qgroup_check_inherit() would return -ENOENT and fail the whole
snapshot creation.

[FIX]
Just skip the check if qgroup is not enabled.
This is to keep the older behavior for user space tools, as if the
kernel behavior changed for user space, it is a regression of kernel.

Thankfully snapper is also fixing the behavior by detecting if qgroup is
running in the first place, so the effect should not be that huge.

Link: https://github.com/openSUSE/snapper/issues/894
Fixes: 86211eea8ae1 ("btrfs: qgroup: validate btrfs_qgroup_inherit parameter")
CC: stable@vger.kernel.org # 6.8+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c