nfc: af_nfc: Fix Spectre v1 vulnerability
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 21 Dec 2018 21:47:53 +0000 (15:47 -0600)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Dec 2018 23:09:25 +0000 (15:09 -0800)
commita95386f0390ab602904d11fe6bd7ea5ef9b136f8
tree2468c24c4cfbe9c94218153587273bdd7ec9493b
parentd686026b1e6ed4ea27d630d8f54f9a694db088b2
nfc: af_nfc: Fix Spectre v1 vulnerability

proto is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

net/nfc/af_nfc.c:42 nfc_sock_create() warn: potential spectre issue 'proto_tab' [w] (local cap)

Fix this by sanitizing proto before using it to index proto_tab.

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/nfc/af_nfc.c