perf/x86: Fix low freqency setting issue
authorKan Liang <kan.liang@linux.intel.com>
Fri, 17 Jan 2025 15:19:11 +0000 (07:19 -0800)
committerIngo Molnar <mingo@kernel.org>
Tue, 25 Feb 2025 13:54:14 +0000 (14:54 +0100)
commit88ec7eedbbd21cad38707620ad6c48a4e9a87c18
tree3db1ada398a43fbf771ca0febf20e0d1c2c48564
parentbddf10d26e6e5114e7415a0e442ec6f51a559468
perf/x86: Fix low freqency setting issue

Perf doesn't work at low frequencies:

  $ perf record -e cpu_core/instructions/ppp -F 120
  Error:
  The sys_perf_event_open() syscall returned with 22 (Invalid argument)
  for event (cpu_core/instructions/ppp).
  "dmesg | grep -i perf" may provide additional information.

The limit_period() check avoids a low sampling period on a counter. It
doesn't intend to limit the frequency.

The check in the x86_pmu_hw_config() should be limited to non-freq mode.
The attr.sample_period and attr.sample_freq are union. The
attr.sample_period should not be used to indicate the frequency mode.

Fixes: c46e665f0377 ("perf/x86: Add INST_RETIRED.ALL workarounds")
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250117151913.3043942-1-kan.liang@linux.intel.com
Closes: https://lore.kernel.org/lkml/20250115154949.3147-1-ravi.bangoria@amd.com/
arch/x86/events/core.c