drm/xe/oa: Don't reset OAC_CONTEXT_ENABLE on OA stream close
authorJosé Roberto de Souza <jose.souza@intel.com>
Tue, 24 Sep 2024 21:37:13 +0000 (14:37 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Thu, 3 Oct 2024 06:23:18 +0000 (01:23 -0500)
commit8135f1c09dd2eecee7cb637f7ec9a29e57300eb8
tree0d9da85c7069ec4fa8215d150189423cac2a1633
parent67801fa67b94ebd0e4da7a77ac2d9f321b75fbe0
drm/xe/oa: Don't reset OAC_CONTEXT_ENABLE on OA stream close

Mesa testing on Xe2+ revealed that when OA metrics are collected for an
exec_queue, after the OA stream is closed, future batch buffers submitted
on that exec_queue do not complete. Not resetting OAC_CONTEXT_ENABLE on OA
stream close resolves these hangs and should not have any adverse effects.

v2: Make the change that we don't reset the bit clearer (Ashutosh)
    Also make the same fix for OAC as OAR (Ashutosh)

Bspec: 60314
Fixes: 2f4a730fcd2d ("drm/xe/oa: Add OAR support")
Fixes: 14e077f8006d ("drm/xe/oa: Add OAC support")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2821
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240924213713.3497992-1-ashutosh.dixit@intel.com
(cherry picked from commit 0c8650b09a365f4a31fca1d1d1e9d99c56071128)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_oa.c