spi: fsl-qspi: use devm function instead of driver remove
authorHan Xu <han.xu@nxp.com>
Wed, 26 Mar 2025 22:41:51 +0000 (17:41 -0500)
committerMark Brown <broonie@kernel.org>
Thu, 27 Mar 2025 19:02:29 +0000 (19:02 +0000)
commit40369bfe717e96e26650eeecfa5a6363563df6e4
treec22adf49865fcc790243acc2ea8d37eb37f61ea3
parentd32c4e58545f17caaa854415f854691e32d42075
spi: fsl-qspi: use devm function instead of driver remove

Driver use devm APIs to manage clk/irq/resources and register the spi
controller, but the legacy remove function will be called first during
device detach and trigger kernel panic. Drop the remove function and use
devm_add_action_or_reset() for driver cleanup to ensure the release
sequence.

Trigger kernel panic on i.MX8MQ by
echo 30bb0000.spi >/sys/bus/platform/drivers/fsl-quadspi/unbind

Cc: stable@vger.kernel.org
Fixes: 8fcb830a00f0 ("spi: spi-fsl-qspi: use devm_spi_register_controller")
Reported-by: Kevin Hao <haokexin@gmail.com>
Signed-off-by: Han Xu <han.xu@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20250326224152.2147099-1-han.xu@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-qspi.c