perf/core: Fix WARN in perf_cgroup_switch()
authorLuo Gengkun <luogengkun@huaweicloud.com>
Wed, 4 Jun 2025 03:39:24 +0000 (03:39 +0000)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 5 Jun 2025 12:37:52 +0000 (14:37 +0200)
commit3172fb986666dfb71bf483b6d3539e1e587fa197
tree3ebaa6627be69da551a028ec86550460ce804a7e
parent3b7a34aebbdf2a4b7295205bf0c654294283ec82
perf/core: Fix WARN in perf_cgroup_switch()

There may be concurrency between perf_cgroup_switch and
perf_cgroup_event_disable. Consider the following scenario: after a new
perf cgroup event is created on CPU0, the new event may not trigger
a reprogramming, causing ctx->is_active to be 0. In this case, when CPU1
disables this perf event, it executes __perf_remove_from_context->
list _del_event->perf_cgroup_event_disable on CPU1, which causes a race
with perf_cgroup_switch running on CPU0.

The following describes the details of this concurrency scenario:

CPU0 CPU1

perf_cgroup_switch:
   ...
   # cpuctx->cgrp is not NULL here
   if (READ_ONCE(cpuctx->cgrp) == NULL)
    return;

perf_remove_from_context:
   ...
   raw_spin_lock_irq(&ctx->lock);
   ...
   # ctx->is_active == 0 because reprogramm is not
   # tigger, so CPU1 can do __perf_remove_from_context
   # for CPU0
   __perf_remove_from_context:
         perf_cgroup_event_disable:
    ...
    if (--ctx->nr_cgroups)
    ...

   # this warning will happened because CPU1 changed
   # ctx.nr_cgroups to 0.
   WARN_ON_ONCE(cpuctx->ctx.nr_cgroups == 0);

[peterz: use guard instead of goto unlock]
Fixes: db4a835601b7 ("perf/core: Set cgroup in CPU contexts for new cgroup events")
Signed-off-by: Luo Gengkun <luogengkun@huaweicloud.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20250604033924.3914647-3-luogengkun@huaweicloud.com
kernel/events/core.c