Danny Al-Gaaf [Wed, 30 Apr 2014 18:48:16 +0000 (20:48 +0200)]
crc/test.c: fix include of time.h
Replace include of time.h with renamed fio_time.h to fix build.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 30 Apr 2014 21:01:00 +0000 (15:01 -0600)]
Makefile: clean all *.d dependency files on make clean
Signed-off-by: Jens Axboe <axboe@fb.com>
Daniel Gollub [Wed, 30 Apr 2014 09:25:04 +0000 (11:25 +0200)]
Rename time.h for third-party include of fio.h
External project might build external ioengines and need to
include there for fio.h. If a project set the include path
to the fio root source directory and the third-party source
holds an "time.h" as well things get complicated.
Signed-off-by: Daniel Gollub <d.gollub@telekom.de>
Cc: Daniel Gollub <daniel.gollub@t-online.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Daniel Gollub [Wed, 30 Apr 2014 06:27:53 +0000 (08:27 +0200)]
Fix gfio build due to disk_stat struct seperation
Signed-off-by: Daniel Gollub <d.gollub@telekom.de>
Cc: Daniel Gollub <daniel.gollub@t-online.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Bruce Cran [Mon, 28 Apr 2014 21:54:43 +0000 (15:54 -0600)]
Windows: always open files in binary mode
On Windows, open() defaults to text mode, causing control characters
to be interpreted. Avoid this by passing the _O_BINARY flag.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 28 Apr 2014 18:08:47 +0000 (12:08 -0600)]
Add option for io_limit
'size' denotes both the size of the region for IO, as well as the
amount of IO to transfer. Sometimes it's useful to be able to set
them separately instead. With this patch, you can do:
size=100G
io_limit=10G
and have fio do 10G of IO between 0..100G of the address space.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 23 Apr 2014 15:59:05 +0000 (09:59 -0600)]
Merge branch 'master' of ssh://git.kernel.dk/data/git/fio
Jens Axboe [Wed, 23 Apr 2014 15:58:39 +0000 (09:58 -0600)]
init: don't set did_arg just for an engine option
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 16 Apr 2014 21:51:27 +0000 (23:51 +0200)]
Error out if the set blocksize is larger than the file size
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Tue, 15 Apr 2014 15:07:44 +0000 (09:07 -0600)]
sg/binject: only restore file flags if they have been set
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Tue, 15 Apr 2014 14:30:06 +0000 (08:30 -0600)]
sg: check for error in fcntl() restore of flags
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Tue, 15 Apr 2014 14:28:51 +0000 (08:28 -0600)]
binject: check for error in fcntl() restore of flags
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Tue, 15 Apr 2014 14:26:57 +0000 (08:26 -0600)]
backend: fix potential division-by-zero
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Tue, 15 Apr 2014 14:25:16 +0000 (08:25 -0600)]
idletime: fix another missing unlock on error
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Tue, 15 Apr 2014 14:18:36 +0000 (08:18 -0600)]
Merge branch 'master' of ssh://git.kernel.dk/data/git/fio
Jens Axboe [Tue, 15 Apr 2014 14:18:08 +0000 (08:18 -0600)]
strcpy: kill last of the suspect ones
Signed-off-by: Jens Axboe <axboe@fb.com>
Bruce Cran [Tue, 15 Apr 2014 00:33:22 +0000 (18:33 -0600)]
Windows: set sizeof(sun_path) to 260 (MAX_PATH).
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:37:46 +0000 (13:37 -0600)]
init: improve command line check for when to print usage/help
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:29:52 +0000 (13:29 -0600)]
init: fix leak bug fix from commit
60c5ec73
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:25:12 +0000 (13:25 -0600)]
disk util: fix bug in strncpy() conversion
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:20:38 +0000 (13:20 -0600)]
Fix potential NULL dereference in alloc_mem_mmap()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:19:13 +0000 (13:19 -0600)]
diskutil: make it clear that parent != NULL for json output
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:16:10 +0000 (13:16 -0600)]
parse: make it clear that 'cp' can't be NULL for o->off1
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:13:21 +0000 (13:13 -0600)]
Fix is_power_of_2() for longs
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:11:19 +0000 (13:11 -0600)]
idletime: unlock ->start_lock in error cases
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 19:09:04 +0000 (13:09 -0600)]
Avoid overwriting allocated pid_file
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 18:20:04 +0000 (12:20 -0600)]
gettime: init 'failed' before use
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 18:15:35 +0000 (12:15 -0600)]
stat: warn on failure to detach DU thread
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 18:14:17 +0000 (12:14 -0600)]
gettime: handle pthread_create() failure
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 18:07:36 +0000 (12:07 -0600)]
init: silence bogus td == NULL warning
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 18:05:22 +0000 (12:05 -0600)]
filesetup: silence bogus warning on close(-1)
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 18:03:22 +0000 (12:03 -0600)]
e4defrag: pass 'error' into td_verror()
Don't use -1 or -Exxxx
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 18:01:45 +0000 (12:01 -0600)]
td_verror() needs errno style error
put_file_log() could pass in -1, we need the actual error instead.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 17:57:05 +0000 (11:57 -0600)]
net engine: get rid of unused struct sockaddr_in6
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 17:45:34 +0000 (11:45 -0600)]
server: ensure that incoming iolog name is NULL terminated
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 17:43:47 +0000 (11:43 -0600)]
server: sanity check incoming command size (and payload)
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 17:36:01 +0000 (11:36 -0600)]
backend: better NULL termination fix for IO scheduler switching
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 16:21:11 +0000 (10:21 -0600)]
num2str: ensure we never access postfix[] out-of-bounds
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 16:13:46 +0000 (10:13 -0600)]
make_filename: another off-by-one buffer issue
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 16:04:21 +0000 (10:04 -0600)]
Error check fcntl() calls
Add a helper to mark an fd as non-blocking, so we can check
and complain in one place.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:52:50 +0000 (09:52 -0600)]
init: remove dead code
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:51:10 +0000 (09:51 -0600)]
backend: fix potential divide-by-zero
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:49:38 +0000 (09:49 -0600)]
stat: fix potential divide-by-zero
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:47:14 +0000 (09:47 -0600)]
idletime: fix potential divide-by-zero
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:45:19 +0000 (09:45 -0600)]
eta: fix potential divide by zero
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:07:30 +0000 (09:07 -0600)]
server: fix missing comma in fio_server_ops[] strings
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:05:46 +0000 (09:05 -0600)]
gettime: use unsigned loop counter
We're comparing with an unsigned exit condition.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 15:04:48 +0000 (09:04 -0600)]
Make td_verror() use an unsigned type
Get rid of warnings stating the input can't be negative.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:59:17 +0000 (08:59 -0600)]
Fix missing sign conversion in ignore_error_type()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:57:35 +0000 (08:57 -0600)]
stat: fix wrong check for whether we have a description or not
It's an array, hence never NULL. Check for size instead.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:55:13 +0000 (08:55 -0600)]
server: fix potential buffer overrun in socket setup path
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:54:09 +0000 (08:54 -0600)]
server: fix potential buffer overrun in bind string
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:50:33 +0000 (08:50 -0600)]
client: fix potential buffer overrun in socket path
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:49:04 +0000 (08:49 -0600)]
net engine: fix potential buffer overrun in socket path
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:45:13 +0000 (08:45 -0600)]
file: fix potential buffer overrun in get_fs_free_counts()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:43:55 +0000 (08:43 -0600)]
verify: fix potential buffer overrun in dump_buf()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:34:43 +0000 (08:34 -0600)]
init: fix potential buffer overrun in make_filename()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:28:08 +0000 (08:28 -0600)]
server: ensure that dus->name is always NULL terminated
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:23:23 +0000 (08:23 -0600)]
stat: check that TEMP environment variable is half-way sane
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Mon, 14 Apr 2014 14:17:30 +0000 (08:17 -0600)]
init: fix more cases of leaking pid_file
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 18:17:53 +0000 (12:17 -0600)]
diskutil: separate out stats from name
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:42:13 +0000 (11:42 -0600)]
init: remove bogus check for NULL parent
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:39:46 +0000 (11:39 -0600)]
Don't leak f_out file desciptor if specified more than once
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:38:38 +0000 (11:38 -0600)]
Don't leak memory if profile option is given twice
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:37:34 +0000 (11:37 -0600)]
server: ensure that server pid file mem is always freed
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:34:17 +0000 (11:34 -0600)]
Ensure that fread() string is always NULL terminated
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:32:49 +0000 (11:32 -0600)]
Fix potentially unterminated string after strncpy() call
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:31:17 +0000 (11:31 -0600)]
Fix leak of directory handle in find_add_disk_slaves() error case
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:29:50 +0000 (11:29 -0600)]
net: fix leak of fd in bind() error path
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:28:54 +0000 (11:28 -0600)]
Fix leak on error path in extend_file()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:27:34 +0000 (11:27 -0600)]
Fix leak of file descriptor in error path of bc_calc()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:25:32 +0000 (11:25 -0600)]
Fix leak of string when doing parse dryrun
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:24:00 +0000 (11:24 -0600)]
Fix directory leak in recurse_dir() on error
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Fri, 11 Apr 2014 17:20:29 +0000 (11:20 -0600)]
Fix leak of 'error' if we don't assign it
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Thu, 10 Apr 2014 22:50:39 +0000 (16:50 -0600)]
Fio 2.1.8
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Thu, 10 Apr 2014 22:08:41 +0000 (00:08 +0200)]
blktrace: fix missing line return in dprint()
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Thu, 10 Apr 2014 22:03:32 +0000 (00:03 +0200)]
iolog: check for thread termination in long delays
If we are doing a long delay now, fio won't be able to kill
the thread when you ctrl-c the job. Split the delay into .5s
intervals, and check for signal in between.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Thu, 10 Apr 2014 14:59:43 +0000 (08:59 -0600)]
Make cache invalidation a soft error
On some platforms, we don't have reliable means of flushing
eg block device caches. Just warn of this fact instead of
erroring out, since the user can't do anything to stop this.
Signed-off-by: Jens Axboe <axboe@fb.com>
Christian Ehrhardt [Thu, 10 Apr 2014 13:09:47 +0000 (15:09 +0200)]
fio: fix s390 timing for older machines/binutils
Older gcc/binutils or one with very low default march will refuse to use stckf.
On top of that machines older than a z196 don not even have the store clock
fast facility.
To fix all of those issues, check for the facilities in configure step and make
the usage of stckf and a matching march dependent to it.
Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 9 Apr 2014 19:58:43 +0000 (13:58 -0600)]
Merge branch 'master' of ssh://git.kernel.dk/data/git/fio
Jens Axboe [Wed, 9 Apr 2014 19:57:38 +0000 (13:57 -0600)]
Add exit_on_io_done option to the CPU IO engine
The CPU IO engine is most often used to saturate the system,
while running an IO load on it. As such, it's useful to have
CPU engine threads exit automatically, when IO has completed.
Add exit_on_io_done as a CPU IO engine option for that purpose.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 9 Apr 2014 03:18:37 +0000 (21:18 -0600)]
iolog: skip max_bs[rw] increment for rw == DDIR_INVAL
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 9 Apr 2014 03:15:09 +0000 (21:15 -0600)]
diskutil: fix potential out-of-bounds array write
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 9 Apr 2014 03:13:42 +0000 (21:13 -0600)]
server: fix fd leak in error case
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 9 Apr 2014 03:07:12 +0000 (21:07 -0600)]
Increment open file count manually
For engines/logs that manually add files, be sure to increment
the open file count.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Wed, 9 Apr 2014 03:03:59 +0000 (21:03 -0600)]
Revert "Fixup ->open_files if not given"
This reverts commit
bcd27f7ae1ccebd2ac1778752bf8f13fa99600e9.
The commit causes us to default to 1 file for cases where
openfiles= isn't set, where before we would default to
nr_files.
Signed-off-by: Jens Axboe <axboe@fb.com>
Conflicts:
filesetup.c
Jens Axboe [Tue, 8 Apr 2014 19:44:37 +0000 (13:44 -0600)]
Merge branch 'master' of ssh://git.kernel.dk/data/git/fio
Jens Axboe [Tue, 8 Apr 2014 19:43:19 +0000 (13:43 -0600)]
blktrace: probe IO depth
Signed-off-by: Jens Axboe <axboe@fb.com>
chenh [Tue, 8 Apr 2014 17:02:26 +0000 (13:02 -0400)]
glusterfs api fadvise support
Christian Ehrhardt [Tue, 8 Apr 2014 15:52:01 +0000 (17:52 +0200)]
fio: fix s390 nop
When trying to run rate limited fio runs we encountered that the current
definition of a nop uses a privileged instruction which is not even a nop,
but a yield call to the hipervisor.
That leads to a SIGILL as it is privileged.
To solve that issue replace it with a nop, the assembler will take care
of it (likely to become a BCR 0,0)
Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Christian Ehrhardt [Tue, 8 Apr 2014 15:52:00 +0000 (17:52 +0200)]
fio: fix s390 time accounting
The current timer implementation could cause time warps on s390 which ends up
as time bound jobs that would never end, because they always reset themself to
the old time.
When touching this code anyway, we also change it to use the faster stckf
and avoid the calibration as we can control the result to be usecs.
This also eliminates a few calculations cycle->usec in the hot path for the
timer.
In case other architectures have similar improved timers that might not be
usec based, but nsec based or such a thing any architecture can set
ARCH_CPU_CLOCK_CYCLES_PER_USEC to an appropriate per-arch value.
This leaves the infrastructure open for others and the compiler will throw
our division by 1 away anyway.
Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Sun, 6 Apr 2014 16:10:32 +0000 (10:10 -0600)]
Support limited mixed command line options and job file
With this, you can now do:
$ fio --timeout=10s --time_based=1 jobfile.fio
and have the command line options work as if they were part
of the global section of jobfile.fio
Note that more advanced uses, like:
$ fio --option_foo=1 jobfile.fio --option_bar=1 jobfile2.fio
will not work, we still clear to default options for
subsequent jobs.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Sun, 6 Apr 2014 16:09:30 +0000 (10:09 -0600)]
Fixup --timeout command line option
Ensure we properly parse the time, use check_str_time()
instead of atoi(). Propagate the timeout correctly to
new jobs.
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Sun, 6 Apr 2014 15:57:59 +0000 (09:57 -0600)]
Merge branch 'master' of ssh://git.kernel.dk/data/git/fio
Jens Axboe [Sun, 6 Apr 2014 15:56:10 +0000 (09:56 -0600)]
Fix crash in setup_files() if no files are defined
Commit
002fe73409d1e moved the division by o->nr_files outside
of the file loop, so for error cases we could end up with
doing the division without having files defined. Crash ensues.
Signed-off-by: Jens Axboe <axboe@fb.com>
Christophe Vu-Brugier [Sun, 6 Apr 2014 13:54:51 +0000 (15:54 +0200)]
Fix some typos in the manpage
Signed-off-by: Christophe Vu-Brugier <cvubrugier@yahoo.fr>
Jens Axboe [Fri, 4 Apr 2014 14:28:17 +0000 (08:28 -0600)]
Makefile: add doc target to generate PDFs from the man pages
Signed-off-by: Jens Axboe <axboe@fb.com>
Bruce Cran [Thu, 3 Apr 2014 18:17:00 +0000 (12:17 -0600)]
Fix JSON_INTEGER overflow on Windows by changing datatype to 'long long'
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Thu, 3 Apr 2014 14:18:07 +0000 (08:18 -0600)]
parse: fix crash with empty FIO_OPT_STR_STORE variables
Sébastien reports:
A crash on solaris & windows (at least) when using fio-2.1.6.1 :
A simple profile that use a env variable : directory=${DIRECTORY}
I'm starting fio without defining DIRECTORY and I'm getting a crash:
The stack on solaris is :
core 'core' of 4574: ./fio ../fio_env.win
0000000100035348 set_name_idx (
ffffffff7fffe970,
100231950, 0, 16c4e8, 0,
1002319b0) + cc
0000000100021a70 add_file (
ffffffff7b400000,
ffffffff7fffee60, 0, 0,
100071c30,
ffffffff7fffe970) + 38
000000010000daf4 add_job.part.4 (7,
100236050, 0,
ffffffff7ffff268, 1, 0) + 11f0
000000010000f444 parse_jobs_ini (0, 0, 0, 1,
100236050,
1002276c0) + 77c
0000000100010db0 parse_options (5118,
ffffffff7ffff968, 1, 0, 0,
10021eef0) + 304
000000010006ff68 main (2,
ffffffff7ffff968,
ffffffff7ffff980,
100228338,
100000000, 2800) + 20
000000010000952c _start (0, 0, 0, 0, 0, 0) + 7c
Same thing happens with filename and other store options. Fix this
by checking in the parser whether the string is empty or not.
Reported-by: Sébastien Bouchex Bellomié <sbouchex@infovista.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Jens Axboe [Thu, 3 Apr 2014 03:47:27 +0000 (21:47 -0600)]
Use setvbuf() for log writing
Check if we have it - if we do, add a 1MB buffer for the file
output. This further speeds up the log writing.
Signed-off-by: Jens Axboe <axboe@fb.com>