linux-2.6-block.git
5 years agostaging: erofs: add on-disk layout
Gao Xiang [Thu, 26 Jul 2018 12:21:44 +0000 (20:21 +0800)]
staging: erofs: add on-disk layout

This commit adds the on-disk layout header file of erofs.

Note that the on-disk layout is still WIP, and some fields are
reserved for the future use by design.

Any comments are welcome.

Thanks-to: Li Guifu <liguifu2@huawei.com>
Thanks-to: Sun Qiuyang <sunqiuyang@huawei.com>
Signed-off-by: Miao Xie <miaoxie@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: fsl-dpaa2/ethsw: document nested structs as per kernel-doc
Ioana Ciornei [Fri, 27 Jul 2018 14:43:18 +0000 (17:43 +0300)]
staging: fsl-dpaa2/ethsw: document nested structs as per kernel-doc

Document nested structs per kernel-doc requirements by moving
all comments before the actual struct.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: fsl-dpaa2/eth: document nested structs as per kernel-doc
Ioana Ciornei [Fri, 27 Jul 2018 14:43:17 +0000 (17:43 +0300)]
staging: fsl-dpaa2/eth: document nested structs as per kernel-doc

Document nested structs per kernel-doc requirements by moving
all comments before the actual struct.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: fsl-dpaa2/eth: Remove unused driver version
Ioana Radulescu [Fri, 27 Jul 2018 14:13:00 +0000 (09:13 -0500)]
staging: fsl-dpaa2/eth: Remove unused driver version

We never really used the driver version, so no point
in keeping it around.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: fsl-dpaa2/eth: Update default hash key
Ioana Radulescu [Fri, 27 Jul 2018 14:12:59 +0000 (09:12 -0500)]
staging: fsl-dpaa2/eth: Update default hash key

In our documentation, we claim to use a 5-tuple key for Rx hash
distribution of flows. The code however configures a key composed
of all supported header fields.

Update the Rx hash key to contain only the documented fields:
{IP src, IP dst, IP nextproto, L4 src, L4 dst}, which was the
original intention and makes most sense as a default.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: fsl-dpaa2/ethsw: Fix error message
Ioana Radulescu [Wed, 25 Jul 2018 14:29:47 +0000 (09:29 -0500)]
staging: fsl-dpaa2/ethsw: Fix error message

Error message was referencing wrong function, fix it.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agoStaging: octeon-usb: Adding SPDX license identifier
Georgios Tsotsos [Thu, 26 Jul 2018 15:41:51 +0000 (18:41 +0300)]
Staging: octeon-usb: Adding SPDX license identifier

Adding appropriate SPDX-License-Identifier (GPL-2) that were missing
from code, header and make files.

Signed-off-by: Georgios Tsotsos <tsotsos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: don't print device addresses as kernel pointers
Todd Poynor [Fri, 27 Jul 2018 03:07:37 +0000 (20:07 -0700)]
staging: gasket: don't print device addresses as kernel pointers

Print device addresses as unsigned long, not as kernel pointers.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: TODO: remove entry for convert to standard logging
Todd Poynor [Fri, 27 Jul 2018 03:07:36 +0000 (20:07 -0700)]
staging: gasket: TODO: remove entry for convert to standard logging

Gasket/apex drivers now use standard logging, remove TODO entry for
this.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: remove gasket logging header
Todd Poynor [Fri, 27 Jul 2018 03:07:35 +0000 (20:07 -0700)]
staging: gasket: remove gasket logging header

Gasket logging functions no longer used.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: apex: convert to standard logging
Todd Poynor [Fri, 27 Jul 2018 03:07:34 +0000 (20:07 -0700)]
staging: gasket: apex: convert to standard logging

Drop gasket logging calls in favor of standard logging.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: sysfs: convert to standard logging
Todd Poynor [Fri, 27 Jul 2018 03:07:33 +0000 (20:07 -0700)]
staging: gasket: sysfs: convert to standard logging

Drop gasket logging calls in favor of standard logging.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: page table: convert to standard logging
Todd Poynor [Fri, 27 Jul 2018 03:07:32 +0000 (20:07 -0700)]
staging: gasket: page table: convert to standard logging

Replace gasket logging calls with standard logging calls.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: ioctl: convert to standard logging
Todd Poynor [Fri, 27 Jul 2018 03:07:31 +0000 (20:07 -0700)]
staging: gasket: ioctl: convert to standard logging

Replace gasket logging calls with standard logging calls.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: interrupt: convert to standard logging
Todd Poynor [Fri, 27 Jul 2018 03:07:30 +0000 (20:07 -0700)]
staging: gasket: interrupt: convert to standard logging

Convert gasket logging calls to standard functions.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: core: convert to standard logging
Todd Poynor [Fri, 27 Jul 2018 03:07:29 +0000 (20:07 -0700)]
staging: gasket: core: convert to standard logging

Use standard logging functions, drop use of gasket log functions.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: save struct device for a gasket device
Todd Poynor [Fri, 27 Jul 2018 03:07:28 +0000 (20:07 -0700)]
staging: gasket: save struct device for a gasket device

Save the struct device pointer to a gasket device in gasket's metadata,
to facilitate use of standard logging calls and in anticipation of
non-PCI gasket devices in the future.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agoMerge tag 'iio-for-4.19b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23...
Greg Kroah-Hartman [Wed, 25 Jul 2018 08:12:07 +0000 (10:12 +0200)]
Merge tag 'iio-for-4.19b' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

Second set of IIO new device support, features and cleanups.

There are also a couple of fixes that can wait for the coming merge
window.

Core new features

* Support for phase channels (used in time of flight sensors amongst
  other things)
* Support for deep UV light channel modifier.

New Device Support

* AD4758 DAC
  - New driver and dt bindings.
* adxl345
  - Support the adxl375 +-200g part which is register compatible.
* isl29501 Time of flight sensor.
  - New driver
* meson-saradc
  - Support the Meson8m2 Socs - right now this is just an ID, but there will
    be additional difference in future.
* mpu6050
  - New ID for 6515 variant.
* si1133 UV sensor.
  - New driver
* Spreadtrum SC27xx PMIC ADC
  - New driver and dt bindings.

Features

* adxl345
  - Add calibration offset readback and writing.
  - Add sampling frequency control.

Fixes and Cleanups

* ad5933
  - Use a macro for the channel definition to reduce duplication.
* ad9523
  - Replace use of core mlock with a local lock. Part of ongoing efforts
    to avoid confusing the purpose of mlock which is only about iio core
    state changes.
  - Fix displayed phase which was out by a factor of 10.
* adxl345
  - Add a link to the datasheet.
  - Rework the use of the address field in the chan_spec structures to
    allow addition of more per channel information.
* adis imu
  - Mark switch fall throughs.
* at91-sama5d2
  - Fix some casting on big endian systems.
* bmp280
  - Drop some DT elements that aren't used and should mostly be done from
    userspace rather than in DT.
* hx711
  - add clock-frequency dt binding and resulting delay to deal with capacitance
    issue on some boards.
  - fix a spurious unit-address in the example.
* ina2xx
  - Avoid a possible kthread_stop with a stale task_struct.
* ltc2632
  - Remove some unused local variables (assigned but value never used).
* max1363
  - Use device_get_match_data to remove some boilerplate.
* mma8452
  - Mark switch fall throughs.
* sca3000
  - Fix a missing return in a switch statement (a bad fallthrough
    previously!)
* sigma-delta-modulator
  - Drop incorrect unit address from the DT example.
* st_accel
  - Use device_get_match_data to drop some boiler plate.
  - Move to probe_new for i2c driver as second parameter not used.
* st_sensors library
  - Use a strlcpy (safe in this case).
* st_lsm6dsx
  - Add some error logging.
* ti-ads7950
  - SPDX
  - Allow simultaneous buffered and polled reads. Needed on a Lego Mindstorms
    EV3 where some channels are used for power supply monitoring at a very low
    rate.
* ti-dac5571
  - Remove an unused variable.
* xadc
  - Drop some dead code.

5 years agoiio: sca3000: Fix missing return in switch
Gustavo A. R. Silva [Sat, 7 Jul 2018 17:44:01 +0000 (12:44 -0500)]
iio: sca3000: Fix missing return in switch

The IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY case is missing a
return and will fall through to the default case and errorenously
return -EINVAL.

Fix this by adding in missing *return ret*.

Fixes: 626f971b5b07 ("staging:iio:accel:sca3000 Add write support to the low pass filter control")
Reported-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
5 years agoiio: ad9523: Fix displayed phase
Lars-Peter Clausen [Mon, 25 Jun 2018 08:03:07 +0000 (11:03 +0300)]
iio: ad9523: Fix displayed phase

Fix the displayed phase for the ad9523 driver. Currently the most
significant decimal place is dropped and all other digits are shifted one
to the left. This is due to a multiplication by 10, which is not necessary,
so remove it.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Fixes: cd1678f9632 ("iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
5 years agostaging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core
Jacob Feder [Mon, 23 Jul 2018 01:27:37 +0000 (21:27 -0400)]
staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core

This IP core has read and write AXI-Stream FIFOs, the contents of which can
be accessed from the AXI4 memory-mapped interface. This is useful for
transferring data from a processor into the FPGA fabric. The driver creates
a character device that can be read/written to with standard
open/read/write/close.

See Xilinx PG080 document for IP details.

https://www.xilinx.com/support/documentation/ip_documentation/axi_fifo_mm_s/v4_1/pg080-axi-fifo-mm-s.pdf

The driver currently supports only store-forward mode with a 32-bit
AXI4 Lite interface. DOES NOT support:
        - cut-through mode
        - AXI4 (non-lite)

Signed-off-by: Jacob Feder <jacobsfeder@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused definition of sQoSCtlLng - Style
John Whitmore [Mon, 23 Jul 2018 20:50:31 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused definition of sQoSCtlLng - Style

Remove sQoSCtlLng. The constant sQoSCtlLng is never used in code so has
been removed. This is a coding style change so should have no impact on
runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused AC_UAPSD definitions - Style
John Whitmore [Mon, 23 Jul 2018 20:50:30 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused AC_UAPSD definitions - Style

Remove the definitions associated with AC_UAPSD. These definitions are
not used in code so have simply been removed. This is a coding style
change and should have no impact on runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused structure ACM - Style
John Whitmore [Mon, 23 Jul 2018 20:50:29 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused structure ACM - Style

Remove the structure ACM as it is unused in code. This change is a coding
style change and should have no impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused enumerated type ACM_METHOD - Style
John Whitmore [Mon, 23 Jul 2018 20:50:28 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused enumerated type ACM_METHOD - Style

Remove the enumerated type ACM_METHOD as it is unused in code. This is
a coding style change and should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused structure WMM_TSPEC - Style
John Whitmore [Mon, 23 Jul 2018 20:50:27 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused structure WMM_TSPEC - Style

Remove the structure WMM_TSPEC as it is unused. This change is a coding
style change and should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused structure QOS_TSTREAM - Style
John Whitmore [Mon, 23 Jul 2018 20:50:26 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused structure QOS_TSTREAM - Style

The structure QOS_TSTREAM is unused in code so has simply been removed.
This change is a coding style change and should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused enumerated type QOS_ELE_SUBTYPE - Style
John Whitmore [Mon, 23 Jul 2018 20:50:25 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused enumerated type QOS_ELE_SUBTYPE - Style

The enumerated type QOS_ELE_SUBTYPE is unused in code so has been removed
from code. This is a coding style change which should have not impact on
runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove the unused AC_CODING definitions - Style
John Whitmore [Mon, 23 Jul 2018 20:50:24 +0000 (21:50 +0100)]
staging:rtl8192u: Remove the unused AC_CODING definitions - Style

The AC_CODING definitions are unused in code, so have simply been removed
from source. This is a coding style change and should not impact runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused union QOS_INFO_FIELD - Style
John Whitmore [Mon, 23 Jul 2018 20:50:23 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused union QOS_INFO_FIELD - Style

The union QOS_INFO_FIELD is unused in code so has been removed from source.
This change is a coding style change so should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused structure QOS_CTRL_FIELD - Style
John Whitmore [Mon, 23 Jul 2018 20:50:22 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused structure QOS_CTRL_FIELD - Style

The structure QOS_CTRL_FIELD is unused in code so has simply been removed
from source. This is a coding style change and should have no impact
on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused structure STA_QOS - Style
John Whitmore [Mon, 23 Jul 2018 20:50:21 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused structure STA_QOS - Style

Remove structure STA_QOS as it is unused in code. This change is a coding
style change so should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Removed unused structure BSS_QOS - Style
John Whitmore [Mon, 23 Jul 2018 20:50:20 +0000 (21:50 +0100)]
staging:rtl8192u: Removed unused structure BSS_QOS - Style

The structure BSS_QOS is not used in code so has simply been removed. The
change is a coding style change and should not impact runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused QOS definitions - Style
John Whitmore [Mon, 23 Jul 2018 20:50:19 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused QOS definitions - Style

Remove the unused QOS related types.

Since definitions are not used simply remove from code. This change is
a coding style change and should not impact runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused enumerated type ACK_POLICY - Style
John Whitmore [Mon, 23 Jul 2018 20:50:18 +0000 (21:50 +0100)]
staging:rtl8192u: Remove unused enumerated type ACK_POLICY - Style

The enumerated type ACK_POLICY is not used in code so it has been removed
from the source code. This is a coding style change and should have no
impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style
John Whitmore [Mon, 23 Jul 2018 20:50:17 +0000 (21:50 +0100)]
staging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style

The typedef of QOS_MODE as a u32 is contrary to coding standard and fails
the checkpatch tests for defining new types in code. Definitions of type
QOS_MODE have simply been replaced with a u32 type.

This is a coding style change which should not impact runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused RTL8258 bit mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:35 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused RTL8258 bit mask definitions - Style

Remove the unused 'RTL8258' bit mask definitions. These definitions fail
the checkpatch CamelCase naming tests. Since the definitions are unused
in code they have been removed, rather then renaming.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused Zebra4 bit mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:34 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused Zebra4 bit mask definitions - Style

Remove the unused 'Zebra4' bit mask definitions. These definitions fail
the checkpatch CamelCase naming tests. Rather then renaming, as the
definitions are unused they have simply been removed.

This is a coding style change which should not impact runtime code
execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused RF Zebra1 Bit Mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:33 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused RF Zebra1 Bit Mask definitions - Style

Remove the unused 'RF Zebra1' bit mask definitions. These definitions
fail the checkpatch CamelCase naming tests. Since the definitions are
unused in code they have simply been removed, rather then renaming.

This is a coding style change which will have no impact on runtime code
execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused Rx Pseduo noise Bit Mask defs - Style
John Whitmore [Sun, 22 Jul 2018 22:10:32 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused Rx Pseduo noise Bit Mask defs - Style

Remove the unused 'Rx Pseduo noise' Bit Mask definitions. These
definitions will fail the checkpatch CamelCase naming test. Since
the definitions are unused in code they have simply been removed,
rather then renaming.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page e Bit Mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:31 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page e Bit Mask definitions - Style

Remove the unused 'page e' Bit Mask definitions. These definitions will
fail the checkpatch CamelCase naming tests. As they are unused in code they
have simply been removed rather then renaming.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page d Bit Mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:30 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page d Bit Mask definitions - Style

Remove the unused 'page d' Bit Mask definitions. These definitions will
fail the checkpatch CamelCase naming test. Since the definitions are
unused in code they have been removed, rather then renaming.

This is a coding style change which should not impact runtime code
execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page c Bit Mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:29 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page c Bit Mask definitions - Style

Remove the unused 'page c' Bit Mask definitions. These definitions will
fail the checkpatch CamelCase naming test. Rather then renaming, as the
definitions are unused in code, they have simply been removed.

The change is a coding style change which should not impact runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page-a Bit Mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:28 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page-a Bit Mask definitions - Style

Remove the unused 'page-a' Bit Mask definitions. These definitions will
fail the checkpatch CamelCase naming tests, rather then renaming, as the
definitions are unused, they have simply been removed.

This is a coding style change and should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page-9 Bit Mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:27 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page-9 Bit Mask definitions - Style

Remove the unused page-9 Bit Mask definitions. These definitions fail
the checkpatch CamelCase naming tests. Since the definitions are unused
in code they have simply been removed, rather then renaming. The change
is purely a coding style change and should not impact runtime code
execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page-8 Bit Mask definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:26 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page-8 Bit Mask definitions - Style

Remove unused 'page-8' Bit Mask definitions. These definitions fail the
checkpatch CamelCase naming test, since they are unused in code they have
simply been removed from code, rather then renamed. This is a coding
style change which should not impact runtime code execution.
 * page-8
 */

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page-1 Bit Masks - Style
John Whitmore [Sun, 22 Jul 2018 22:10:25 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page-1 Bit Masks - Style

Remove the unused 'page-1' Bit Masks. These definitions fail the
checkpatch CamelCase naming test. To avoid renaming the definitions
have simply been removed. This is a coding style change which should
have no impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused RTL8258 definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:24 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused RTL8258 definitions - Style

Remove the unused RTL8258 definitions. These definitions fail the checkpatch
CamelCase naming test, rather then renaming, as the definitions are unused
they have simply been removed. This is a coding style change which should
not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused Zebra4 definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:23 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused Zebra4 definitions - Style

Remove the unused 'Zebra4' definitions. These definitions fail the
checkpatch CamelCase naming test, rather then rename as they are unused
definitions they have simply been removed. This is a coding style
change which should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused Zebra1 definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:22 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused Zebra1 definitions - Style

Remove unused 'Zebra1' definitions. These definitions fail the checkpatch
CamelCase test, rather then rename, these unused definitions have simply
been removed. This is a coding style change which should have not impact
on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page d definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:21 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page d definitions - Style

Remove the unused 'page d' definitions. These definitions fail the
checkpatch CamelCase naming test. Rather then renaming unused
definitions they have simply been removed. This change is a coding
style change and should have no impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page c definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:20 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page c definitions - Style

Remove unused 'page c' definitions. These definitions fail the checkpatch
CamelCase test, to save renaming, these unused definitions have simply
been removed. This is a coding style change which should not have an
impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page a definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:19 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page a definitions - Style

Remove unused 'page a' definitions. These definitions fail the checkpatch
CamelCase naming test, rather then renaming these unused definitions they
have simply been removed. This is a coding style change only, and should
have no impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page 9 definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:18 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page 9 definitions - Style

Remove the unused definitions from page 9 section.

These definitions will fail the checkpatch CamelCase test, to save renaming
these unused definitions they have simply been removed. This is a coding
style change which should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page 8 definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:17 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page 8 definitions - Style

Remove page 8 definitions which are never used in code.

Many of these definitions, if not all, fail the checkpatch CamelCase
checks. To avoid the effort of renaming unused definitions they have
been removed. This is a style change which should have no impact on
runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove unused page 1 definitions - Style
John Whitmore [Sun, 22 Jul 2018 22:10:16 +0000 (23:10 +0100)]
staging:rtl8192u: Remove unused page 1 definitions - Style

Remove all the "page 1" definitions as they are not used in code.

A lot of these definitions, if not all, fail checkpatch because of
CamelCase issues. Rather then change the names of unused constants
simply remove. This is a coding style change which should have no
impact on runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename variable State > state - Style
John Whitmore [Sat, 21 Jul 2018 19:25:52 +0000 (20:25 +0100)]
staging:rtl8192u: Rename variable State > state - Style

Rename the variable State to state, this clears the checkpatch issue
with CamelCase naming. The change is purely coding style and should
not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename MaxTxPwrDbmList > max_tx_pwr_dbm_list - Style
John Whitmore [Sat, 21 Jul 2018 19:25:51 +0000 (20:25 +0100)]
staging:rtl8192u: Rename MaxTxPwrDbmList > max_tx_pwr_dbm_list - Style

Rename the member variable MaxTxPwrDbmList to max_tx_pwr_dbm_list. This
change clears the checkpatch issue with CamelCase naming. The change is
a simple coding style change which should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename CountryIeWatchdog > country_ie_watchdog - Style
John Whitmore [Sat, 21 Jul 2018 19:25:50 +0000 (20:25 +0100)]
staging:rtl8192u: Rename CountryIeWatchdog > country_ie_watchdog - Style

Rename the member variable CountryIeWatchdog to country_ie_watchdog, this
change clears the checkpatch issue with CamelCase naming of variables.
The change is a simple coding style change which should not impact runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename variable CountryIeSrcAddr - Style
John Whitmore [Sat, 21 Jul 2018 19:25:49 +0000 (20:25 +0100)]
staging:rtl8192u: Rename variable CountryIeSrcAddr - Style

Rename the member variable CountryIeSrcAddr to country_ie_src_addr, this
clears the checkpatch issue with CamelCase naming. The change is purely a
coding style change and should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename CountryIeBuf to country_ie_buf - Style
John Whitmore [Sat, 21 Jul 2018 19:25:48 +0000 (20:25 +0100)]
staging:rtl8192u: Rename CountryIeBuf to country_ie_buf - Style

Rename the member variable CountryIeBuf to country_ie_buf. This change clears
the checkpatch issue with CamelCase. The change is purely coding style and
should not impact runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename CountryIeLen > country_ie_len - Style
John Whitmore [Sat, 21 Jul 2018 19:25:47 +0000 (20:25 +0100)]
staging:rtl8192u: Rename CountryIeLen > country_ie_len - Style

Rename CountryIeLen to country_ie_len, coding style change to clear
checkpatch issue with CamelCase naming. The change should have no
impact on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename bEnabled > enabled - Style
John Whitmore [Sat, 21 Jul 2018 19:25:46 +0000 (20:25 +0100)]
staging:rtl8192u: Rename bEnabled > enabled - Style

Rename the member variable bEnabled to enabled. This change clears the
checkpatch issue with CamelCase. Purely a coding style change which should not
impact runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Remove typedef and rename struct RT_DOT11D_INFO - Style
John Whitmore [Sat, 21 Jul 2018 19:25:45 +0000 (20:25 +0100)]
staging:rtl8192u: Remove typedef and rename struct RT_DOT11D_INFO - Style

Removed the typedef from structure RT_DOT11D_INFO. This change clears the
checkpatch issue with declaring new types.

Rename the structure from RT_DOT11D_INFO to rt_dot11d_info.

Coding style changes which should not impact runtime execution of code.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename TClasNum > t_clas_num - Style
John Whitmore [Sat, 21 Jul 2018 19:25:44 +0000 (20:25 +0100)]
staging:rtl8192u: Rename TClasNum > t_clas_num - Style

Rename the struct TS_COMMON_INFO member variable TClasNum to t_clas_num. This
change clears the checkpatch issue with CamelCase naming. There should be no
impact on runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging:rtl8192u: Rename TClasProc > t_clas_proc - Style
John Whitmore [Sat, 21 Jul 2018 19:25:43 +0000 (20:25 +0100)]
staging:rtl8192u: Rename TClasProc > t_clas_proc - Style

Rename the struct TS_COMMON_INFO member variable TClasProc to
t_clas_proc. This change clears the checkpatch issue with
CamelCase variable names. There should be no impact on
runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: fix lines over 80 characters
Michael Straube [Sat, 21 Jul 2018 18:57:42 +0000 (20:57 +0200)]
staging: rtl8188eu: fix lines over 80 characters

Fix two lines over 80 characters by removing unnecessary parentheses.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: replace tabs with spaces
Michael Straube [Sat, 21 Jul 2018 18:57:41 +0000 (20:57 +0200)]
staging: rtl8188eu: replace tabs with spaces

Replace tabs with spaces or just remove tabs where appropriate.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: remove unnecessary parentheses
Michael Straube [Sat, 21 Jul 2018 18:57:40 +0000 (20:57 +0200)]
staging: rtl8188eu: remove unnecessary parentheses

Remove unnecessary parentheses.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: fix comparsions to true
Michael Straube [Sat, 21 Jul 2018 18:57:39 +0000 (20:57 +0200)]
staging: rtl8188eu: fix comparsions to true

Use if(x) instead of if(x == true).

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: change return type to bool
Michael Straube [Sat, 21 Jul 2018 18:57:38 +0000 (20:57 +0200)]
staging: rtl8188eu: change return type to bool

Both rtw_is_cckrates_included() and rtw_is_cckratesonly_included()
return true or false. Change the return type from uint to bool.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: refactor rtw_is_cckratesonly_included()
Michael Straube [Sat, 21 Jul 2018 18:57:37 +0000 (20:57 +0200)]
staging: rtl8188eu: refactor rtw_is_cckratesonly_included()

Refactor rtw_is_cckratesonly_included() to improve readability and
slightly reduce object file size.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: refactor rtw_is_cckrates_included()
Michael Straube [Sat, 21 Jul 2018 18:57:36 +0000 (20:57 +0200)]
staging: rtl8188eu: refactor rtw_is_cckrates_included()

Refactor rtw_is_cckrates_included() to improve readability and
slightly reduce object file size.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu: remove blank lines
Michael Straube [Sat, 21 Jul 2018 18:57:35 +0000 (20:57 +0200)]
staging: rtl8188eu: remove blank lines

Remove unrequired blank lines reported by checkpatch.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: bcm2835-camera: fix timeout handling in wait_for_completion_timeout
Nicholas Mc Guire [Sat, 21 Jul 2018 13:20:28 +0000 (15:20 +0200)]
staging: bcm2835-camera: fix timeout handling in wait_for_completion_timeout

wait_for_completion_timeout returns unsigned long not int so a variable of
proper type is introduced. Further the check for <= 0 is ambiguous and should
be == 0 here indicating timeout which is the only error case so no additional
check needed here.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: dgnc: dgnc_tty.c: Avoid '(' at the end of line
Nishad Kamdar [Sun, 22 Jul 2018 18:48:01 +0000 (00:18 +0530)]
staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line

Bring the first argument to the previous line,
remove a superfluous () in the second argument
by using !, and align the lines to match open
parenthesis. Issue found by checkpatch.

Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: bcm2835-camera: handle wait_for_completion_timeout return properly
Nicholas Mc Guire [Sat, 21 Jul 2018 11:31:24 +0000 (13:31 +0200)]
staging: bcm2835-camera: handle wait_for_completion_timeout return properly

wait_for_completion_timeout returns unsigned long not int so a variable of
proper type is introduced. Further the check for <= 0 is ambiguous and
should be == 0 here indicating timeout.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: use vzalloc instead of vmalloc/memset
Ivan Bornyakov [Mon, 23 Jul 2018 18:30:25 +0000 (21:30 +0300)]
staging: gasket: use vzalloc instead of vmalloc/memset

Use vzalloc instead of vmalloc followed by memset with 0.

Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: apex: convert various logs to debug level
Todd Poynor [Sat, 21 Jul 2018 13:35:07 +0000 (06:35 -0700)]
staging: gasket: apex: convert various logs to debug level

Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: page table: remove unnecessary logs
Todd Poynor [Sat, 21 Jul 2018 13:35:06 +0000 (06:35 -0700)]
staging: gasket: page table: remove unnecessary logs

Some error logs in page table handling code could only be hit in
cases of programming errors not expected in the current code base, and
aren't likely to be useful on their own.  Remove these.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: page table: convert various logs to debug level
Todd Poynor [Sat, 21 Jul 2018 13:35:05 +0000 (06:35 -0700)]
staging: gasket: page table: convert various logs to debug level

Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: ioctl common: convert various logs to debug level
Todd Poynor [Sat, 21 Jul 2018 13:35:04 +0000 (06:35 -0700)]
staging: gasket: ioctl common: convert various logs to debug level

Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: interrupts: convert various logs to debug level
Todd Poynor [Sat, 21 Jul 2018 13:35:03 +0000 (06:35 -0700)]
staging: gasket: interrupts: convert various logs to debug level

Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: core: convert various logs to debug level
Todd Poynor [Sat, 21 Jul 2018 13:35:02 +0000 (06:35 -0700)]
staging: gasket: core: convert various logs to debug level

Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: apex return error on sysfs show of missing attribute
Todd Poynor [Sat, 21 Jul 2018 13:35:01 +0000 (06:35 -0700)]
staging: gasket: apex return error on sysfs show of missing attribute

Apex sysfs show function return -ENODEV if the attribute is not present,
rather than silently failing from the standpoint of the userspace
accessor.

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: gasket_get_device drop check for NULL pci_dev
Todd Poynor [Sat, 21 Jul 2018 13:35:00 +0000 (06:35 -0700)]
staging: gasket: gasket_get_device drop check for NULL pci_dev

The pci_dev field of a struct gasket_dev can never be NULL, there's no
need to check for this in gasket_get_device().

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: remove unnecessary NULL checks on calls from VFS
Todd Poynor [Sat, 21 Jul 2018 13:34:59 +0000 (06:34 -0700)]
staging: gasket: remove unnecessary NULL checks on calls from VFS

Remove unneeded checks for NULL pointers in struct file pointers passed
from the VFS layer or the private_data that must have been properly set
at file open time.

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: print mmap starting address as unsigned long
Todd Poynor [Sat, 21 Jul 2018 13:34:58 +0000 (06:34 -0700)]
staging: gasket: print mmap starting address as unsigned long

Page alignment error log should print the offending value as an unsigned
long, not as a kernel pointer.

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: avoid copy to user on error in coherent alloc config
Todd Poynor [Sat, 21 Jul 2018 13:34:57 +0000 (06:34 -0700)]
staging: gasket: avoid copy to user on error in coherent alloc config

gasket_config_coherent_allocator() on error return the error to caller
without copying a possibly-update DMA address back to userspace.

Reported-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: gasket_handle_ioctl fix ioctl exit trace param
Todd Poynor [Sat, 21 Jul 2018 13:34:56 +0000 (06:34 -0700)]
staging: gasket: gasket_handle_ioctl fix ioctl exit trace param

Pass the return value from the device ioctl permissions callback to the
tracepoint when the callback returns an error.

Reported-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: remove duplicate call to retrieve device callback
Todd Poynor [Sat, 21 Jul 2018 13:34:55 +0000 (06:34 -0700)]
staging: gasket: remove duplicate call to retrieve device callback

gasket_handle_ioctl() calls gasket_get_ioctl_permissions_cb() twice;
simplify the code and avoid duplicated work by fetching the callback
pointer only once.

Reported-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: gasket: fix check_and_invoke_callback log param
Todd Poynor [Sat, 21 Jul 2018 13:34:54 +0000 (06:34 -0700)]
staging: gasket: fix check_and_invoke_callback log param

The message should be passed the callback function pointer, not
the pointer to the gasket device.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: rtl8188eu/rtl8723bs: fix character encoding
Arnd Bergmann [Tue, 24 Jul 2018 11:13:28 +0000 (13:13 +0200)]
staging: rtl8188eu/rtl8723bs: fix character encoding

drivers/staging/rtl8188eu/include/odm.h uses an incorrect encoding
for the '...' character in two comments, which makes it one of the
few non-UTF-8 source files.

This removes the odd characters and uses the same ASCII representation
that we have in the regular rtlwifi driver. The second instance
of drivers/staging/rtl8723bs/hal/odm.h is garbled in a different way,
so I change it to be the same as well even though it is already
plain ASCII.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: wilc1000: use descriptor-based interface for GPIO
Ajay Singh [Fri, 20 Jul 2018 12:01:38 +0000 (17:31 +0530)]
staging: wilc1000: use descriptor-based interface for GPIO

Now making use of descriptor-based interface instead of integer-based
interface for IRQ GPIO.
Added device tree binding reference for WILC SDIO and SPI interface
module. Also moved the code to free gpio descriptor in module remove
as the reference was fetched in probe function.
Updated the TODO file

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: wilc1000: change compatible string from atmel to microchip
Ajay Singh [Fri, 20 Jul 2018 12:01:37 +0000 (17:31 +0530)]
staging: wilc1000: change compatible string from atmel to microchip

Use 'microchip' in compatible string instead of 'atmel', also replace '_'
with '-' before the module. Remove 'wilc1000' prefix from device table
name.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: wilc1000: rename variable from 'gpio' to 'gpio_irq'
Ajay Singh [Fri, 20 Jul 2018 12:01:36 +0000 (17:31 +0530)]
staging: wilc1000: rename variable from 'gpio' to 'gpio_irq'

Rename from 'gpio' to 'gpio_irq', so its inlcude the information about
the purpose of GPIO.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agostaging: wilc1000: remove gpio parameter from wilc_netdev_init()
Ajay Singh [Fri, 20 Jul 2018 12:01:35 +0000 (17:31 +0530)]
staging: wilc1000: remove gpio parameter from wilc_netdev_init()

Instead of passing the gpio as parameter to wilc_netdev_init() now
setting its value after finishing wilc_netdev_init() call. Avoided
passing of extra parameter to wilc_netdev_init().

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5 years agoiio: adc: meson-saradc: add support for the Meson8m2 SoCs
Martin Blumenstingl [Sat, 21 Jul 2018 19:40:49 +0000 (21:40 +0200)]
iio: adc: meson-saradc: add support for the Meson8m2 SoCs

The SAR ADC on Meson8m2 behaves identical to the one found in the
Meson8b SoCs. Add a separate compatible string because the temperature
sensor logic (not supported yet) differs between Meson8 and Meson8m2
(however, it's the same for Meson8b and Meson8m2).

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
5 years agodt-bindings: iio: adc: add Meson8m2 support
Martin Blumenstingl [Sat, 21 Jul 2018 19:40:48 +0000 (21:40 +0200)]
dt-bindings: iio: adc: add Meson8m2 support

The Amlogic Meson SAR ADC implementation on the Meson8m2 SoC is
identical to the Meson8b variant. Add a compatible string to indicate
that we support the SAR ADC on the Meson8m2 SoC.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
5 years agoiio: adc: ti-ads7950: allow simultaneous use of buffer and direct mode
David Lechner [Sat, 21 Jul 2018 19:37:34 +0000 (14:37 -0500)]
iio: adc: ti-ads7950: allow simultaneous use of buffer and direct mode

This modifies the TI ADS7950 A/DC driver to allow the simultaneous use
of both the triggered buffer and reading channels directly (via in-
kernel API or sysfs).

The use case for this is on LEGO MINDSTORMS EV3. Two of the voltage
channels are used in-kernel by a power supply driver, which reads the
values using iio_read_channel_processed(). These channels are only read
at a slow rate (<= 1Hz).  However, we want to be able to read 12 other
channels at the same time using the triggered buffer at a high rate (>=
100Hz).

Signed-off-by: David Lechner <david@lechnology.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>