Michael Rubin [Wed, 9 Apr 2025 05:59:03 +0000 (05:59 +0000)]
staging: gpib: local_ppoll_mode_ioctl_t now short
Using Linux code style to replace typedef local_ppoll_mode_ioctl_t with
type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-22-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:59:02 +0000 (05:59 +0000)]
staging: gpib: autospoll_ioctl_t now short
Using Linux code style to replace typedef autospoll_ioctl_t with type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-21-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:59:01 +0000 (05:59 +0000)]
staging: gpib: t1_delay_ioctl_t now unsigned int
Using Linux code style to replace typedef t1_delay_ioctl_t with type
unsigned int.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-20-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:59:00 +0000 (05:59 +0000)]
staging: gpib: rsc_ioctl_t now int
Using Linux code style to replace typedef rsc_ioctl_t with type int.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-19-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:59 +0000 (05:58 +0000)]
staging: gpib: event_ioctl_t now short
Using Linux code style to replace typedef event_ioctl_t with type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-18-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:58 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_request_service2
Using Linux code style for 'struct gpib_request_service2' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-17-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:57 +0000 (05:58 +0000)]
staging: gpib: Using gpib_select_device_path_ioctl
Using Linux code style for 'struct gpib_select_device_path_ioctl' to
remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-16-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:56 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_sad_ioctl
Using Linux code style for 'struct gpib_sad_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-15-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:55 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_pad_ioctl
Using Linux code style for 'struct gpib_pad_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-14-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:54 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_ppoll_config_ioctl`
Using Linux code style for 'struct gpib_ppoll_config_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-13-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:53 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_select_pci_ioctl
Using Linux code style for 'struct gpib_select_pci_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-12-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:52 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_board_info_ioctl
Using Linux code style for 'struct gpib_board_info_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-11-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:51 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_spoll_bytes_ioctl
Using Linux code style for 'struct gpib_spoll_bytes_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-10-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:50 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_online_ioctl
Using Linux code style for 'struct gpib_online_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-9-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:49 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_wait_ioctl
Using Linux code style for 'struct gpib_wait_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-8-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:48 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_eos_ioctl
Using Linux code style for 'struct gpib_eos_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-7-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:47 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_serial_poll_ioctl
Using Linux code style for 'struct gpib_serial_poll_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-6-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:46 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_close_dev_ioctl
Using Linux code style for 'struct gpib_close_dev_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-5-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:45 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_open_dev_ioctl
Using Linux code style for 'struct gpib_open_dev_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-4-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:44 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_read_write_ioctl
Using Linux code style for 'struct gpib_read_write_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 05:58:43 +0000 (05:58 +0000)]
staging: gpib: Using struct gpib_board_type_ioctl
Using Linux code style for 'struct gpib_board_type_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:39 +0000 (18:09 +0000)]
staging: gpib: ines: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-10-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:38 +0000 (18:09 +0000)]
staging: gpib: tms9914: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-9-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:37 +0000 (18:09 +0000)]
staging: gpib: nec7210: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-8-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:36 +0000 (18:09 +0000)]
staging: gpib: gpib_types: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-7-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:35 +0000 (18:09 +0000)]
staging: gpib: gpib_proto: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-6-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:34 +0000 (18:09 +0000)]
staging: gpib: fmh_gpib: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-5-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:33 +0000 (18:09 +0000)]
staging: gpib: fluke_gpib: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-4-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:32 +0000 (18:09 +0000)]
staging: gpib: ibsys: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 18:09:31 +0000 (18:09 +0000)]
staging: gpib: cb7210: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409180953.398686-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 23:25:35 +0000 (23:25 +0000)]
staging: gpib: Remove typedef gpib_file_private_t
Removing gpib_file_private_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408232535.187528-8-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 23:25:34 +0000 (23:25 +0000)]
staging: gpib: Removing typedef gpib_descriptor_t
Removing gpib_descriptor_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408232535.187528-7-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 23:25:33 +0000 (23:25 +0000)]
staging: gpib: Removing typedef of status_byte
Replacing typedef of status_byte_t with struct gpib_status_byte to adhere to
Linux coding style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408232535.187528-6-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 23:25:32 +0000 (23:25 +0000)]
staging: gpib: Removing typedef gpib_status_queue
Removing gpib_status_queue_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408232535.187528-5-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 23:25:31 +0000 (23:25 +0000)]
staging: gpib: Removing gpib_event_t typedef
Removing gpib_event_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408232535.187528-4-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 23:25:30 +0000 (23:25 +0000)]
staging: gpib: Removing gpib_interface_list_t
Removing gpib_interface_list_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408232535.187528-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 23:25:29 +0000 (23:25 +0000)]
staging: gpib: Removing typedef gpib_event_queue
Removing gpib_event_queue_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408232535.187528-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 06:39:04 +0000 (06:39 +0000)]
staging: gpib: Removing function ibAPE
Reported by checkpatch.pl as CamelCase where function is undefined.
CHECK: Avoid CamelCase: <ibAPE>
Removing undefined function.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409063904.342292-7-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 06:39:03 +0000 (06:39 +0000)]
staging: gpib: Removing function ibaPrsp
Reported by checkpatch.pl as CamelCase where function is undefined.
CHECK: Avoid CamelCase: <ibaPrsp>
Removing undefined function.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409063904.342292-6-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 06:39:02 +0000 (06:39 +0000)]
staging: gpib: Removing function ibAPWait
Reported by checkpatch.pl as CamelCase where function is undefined.
CHECK: Avoid CamelCase: <ibaAPWait>
Removing undefined function.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409063904.342292-5-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 06:39:01 +0000 (06:39 +0000)]
staging: gpib: Removing function osSendEOI
Reported by checkpatch.pl as CamelCase where function is undefined.
CHECK: Avoid CamelCase: <osSendEOI>
Removing undefined function which appears twice.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409063904.342292-4-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 06:39:00 +0000 (06:39 +0000)]
staging: gpib: Removing function osReset
Reported by checkpatch.pl as CamelCase where function is undefined.
CHECK: Avoid CamelCase: <osReset>
Removing undefined function.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409063904.342292-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Wed, 9 Apr 2025 06:38:59 +0000 (06:38 +0000)]
staging: gpib: Removing function osInit
Reported by checkpatch.pl as CamelCase where function is undefined.
CHECK: Avoid CamelCase: <osInit>
Removing undefined function.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409063904.342292-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:56:28 +0000 (22:56 +0000)]
staging: gpib: agilent_82357a uses completion
agilent_82357a_send_bulk_msg is a oneshot event where a semphore is meant for
synchronizing over counting events.
Recommendation is to use a completion instead.
Reported by checkpatch.
WARNING: consider using a completion
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408225628.187316-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:58 +0000 (22:36 +0000)]
staging: gpib: Removing typedef gpib_board_config
Removing gpib_interface_t to adhere to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-19-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:57 +0000 (22:36 +0000)]
staging: gpib: tnt4882: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-18-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:56 +0000 (22:36 +0000)]
staging: gpib: pc2: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-17-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:55 +0000 (22:36 +0000)]
staging: gpib: ni_usb: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-16-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:54 +0000 (22:36 +0000)]
staging: gpib: lpvo_usb: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-15-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:53 +0000 (22:36 +0000)]
staging: gpib: ines: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-14-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:52 +0000 (22:36 +0000)]
staging: gpib: gpibP: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-13-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:51 +0000 (22:36 +0000)]
staging: gpib: hp_82341: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-12-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:50 +0000 (22:36 +0000)]
staging: gpib: hp_82335: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-11-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:49 +0000 (22:36 +0000)]
staging: gpib: gpio: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-10-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:48 +0000 (22:36 +0000)]
staging: gpib: fmh: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-9-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:47 +0000 (22:36 +0000)]
staging: gpib: eastwood: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-8-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:46 +0000 (22:36 +0000)]
staging: gpib: common: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-7-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:45 +0000 (22:36 +0000)]
staging: gpib: cec: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-6-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:44 +0000 (22:36 +0000)]
staging: gpib: cb7210: struct gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-5-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:43 +0000 (22:36 +0000)]
staging: gpib: agilent_82357a: gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-4-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:42 +0000 (22:36 +0000)]
staging: gpib: agilent_82350b: gpib_board_config
Using Linux code style for struct gpib_board_config
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:36:41 +0000 (22:36 +0000)]
staing: gpib: struct typing for gpib_board_config
Using Linux code style for gpib_board_config struct in .h to allow drivers to
migrate.
Adhering to Linux code style.
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Reported by CheckPatch
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408223659.187109-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:40 +0000 (22:20 +0000)]
staging: gpib: tms9914: Fix Improper SPDX comment.
Correct Improper SPDX comment style.
Adhere to Linux kernel coding style.
Reported by checkpatch
WARNING: Improper SPDX comment style .../tms9914.h', please use '/*' instead
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-15-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:39 +0000 (22:20 +0000)]
staging: gpib: nec: Fix Improper SPDX comment.
Correct Improper SPDX comment style.
Adhere to Linux kernel coding style.
Reported by checkpatch
WARNING: Improper SPDX comment style .../nec7210.h', please use '/*' instead
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-14-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:38 +0000 (22:20 +0000)]
staging: gpib: uapi: Fix CamelCase and IB_STB
Correct CamelCase for IB_STB enums
Adhere to Linux kernel coding style.
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-13-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:37 +0000 (22:20 +0000)]
staging: gpib: uapi: Fix CamelCase and IBC Dup
Resolved duplicate entry for IbcSPollBit vs IbcSpollBit.
Correct CamelCase for IBC enums
Adhere to Linux kernel coding style.
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-12-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:36 +0000 (22:20 +0000)]
staging: gpib: uapi: Fix CamelCase and IBA Dup
Resolved duplicate entry for IbaSPollBit vs IbaSpollBit.
Correct CamelCase for IBA enums
Adhere to Linux kernel coding style.
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-11-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:35 +0000 (22:20 +0000)]
staging: gpib: tnt4882: lines exceeded 100 columns
Adhere to Linux kernel coding style.
CHECK: line length exceeds 100 columns
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-10-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:34 +0000 (22:20 +0000)]
staging: gpib: pc2: lines exceeded 100 columns
Adhere to Linux kernel coding style.
CHECK: line length exceeds 100 columns
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-9-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:33 +0000 (22:20 +0000)]
staging: gpib: ines: lines exceeded 100 columns
Adhere to Linux kernel coding style.
CHECK: line length exceeds 100 columns
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-8-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:32 +0000 (22:20 +0000)]
staging: gpib: tms9914: lines exceeded 100 columns
Adhere to Linux kernel coding style.
CHECK: line length exceeds 100 columns
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-7-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:31 +0000 (22:20 +0000)]
staging: gpib: nec: lines exceeded 100 columns
Adhere to Linux kernel coding style.
CHECK: line length exceeds 100 columns
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-6-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:30 +0000 (22:20 +0000)]
staging: gpib: common: lines exceeded 100 columns
Adhere to Linux kernel coding style.
CHECK: line length exceeds 100 columns
Reported by checkpatch
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-5-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:29 +0000 (22:20 +0000)]
staging: gbip: Alignment should match open parens
Adhere to Linux kernel coding style.
Reported by checkpatch
CHECK: Alignment should match open parenthesis
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-4-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:28 +0000 (22:20 +0000)]
staging: gpib: Correct CamelCase for PPConfig
Adhere to Linux kernel coding style.
Reported by checkpatch
CHECK: Avoid CamelCase: <PPConfig>
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Rubin [Tue, 8 Apr 2025 22:20:27 +0000 (22:20 +0000)]
staging: gpib: Correct CamelCase for EVENT enums
Adhere to Linux kernel coding style.
Reported by checkpatch
CHECK: Avoid CamelCase: <EventNone>
CHECK: Avoid CamelCase: <EventDevTrg>
CHECK: Avoid CamelCase: <EventDevClr>
CHECK: Avoid CamelCase: <EventIfc>
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250408222040.186881-2-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andy Shevchenko [Tue, 8 Apr 2025 14:22:26 +0000 (17:22 +0300)]
fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'
Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'
for the sake of deduplication.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20250408142554.1366319-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andy Shevchenko [Tue, 8 Apr 2025 14:22:25 +0000 (17:22 +0300)]
fbtft: Unorphan the driver
Let's maintain occasional fixes to the fbtft driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250408142554.1366319-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Akintola [Tue, 8 Apr 2025 10:20:40 +0000 (11:20 +0100)]
staging: sm750fb: change sii164ClearInterrupt to snake_case
Change camelCase function name sii164ClearInterrupt to
sii164_clear_interrupt in order to conform to kernel code styles
as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ClearInterrupt>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
Link: https://lore.kernel.org/r/549b645b265edcb793458a534427f75f0ea343c4.1744105389.git.princerichard17a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Akintola [Tue, 8 Apr 2025 10:20:39 +0000 (11:20 +0100)]
staging: sm750fb: change sii164CheckInterrupt to snake_case
Change camelCase function name sii164CheckInterrupt to
sii164_check_interrupt in order to conform to kernel code styles
as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164CheckInterrupt>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
Link: https://lore.kernel.org/r/c5c01f1840ca37c24fcca7bff4b09adba37c3a7f.1744105389.git.princerichard17a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Akintola [Tue, 8 Apr 2025 10:20:38 +0000 (11:20 +0100)]
staging: sm750fb: change sii164IsConnected to snake_case
Change camelCase function name sii164IsConnected to sii164_is_connected
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164IsConnected>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
Link: https://lore.kernel.org/r/05de0fb87ed53015cd01ef9460996597ef1e09c8.1744105389.git.princerichard17a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Akintola [Tue, 8 Apr 2025 10:20:37 +0000 (11:20 +0100)]
staging: sm750fb: change sii164EnableHotPlugDetection to snake_case
Change camelCase function name sii164EnableHotPlugDetection to sii164_enable_hot_plug_detection
and it's parameter enableHotPlug to enable_hot_plug
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164EnableHotPlugDetection>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
Link: https://lore.kernel.org/r/04907f753bc0d1a2b2095ffba1d066516520fbb8.1744105389.git.princerichard17a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Akintola [Tue, 8 Apr 2025 10:20:36 +0000 (11:20 +0100)]
staging: sm750fb: change sii164GetChipString to snake_case
Change camelCase function name sii164GetChipString to sii164_get_chip_string
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetChipString>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
Link: https://lore.kernel.org/r/08eb6104c7b82aea32796163421a7e795d3d8964.1744105389.git.princerichard17a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Akintola [Tue, 8 Apr 2025 10:20:35 +0000 (11:20 +0100)]
staging: sm750fb: change sii164SetPower to snake_case
Change camelCase function name sii164SetPower to sii164_set_power
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164SetPower>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
Link: https://lore.kernel.org/r/90f9842254eb83c2dc19abcf5072aab9549026a9.1744105389.git.princerichard17a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Akintola [Tue, 8 Apr 2025 10:20:34 +0000 (11:20 +0100)]
staging: sm750fb: change sii164ResetChip to snake_case
Change camelCase function name sii164ResetChip to sii164_reset_chip
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ResetChip>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
Link: https://lore.kernel.org/r/0974eb17fa67b707e8d2972668da4d8a692a9702.1744105388.git.princerichard17a@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Brown [Tue, 15 Apr 2025 13:31:51 +0000 (14:31 +0100)]
staging: bcm2835-audio: Validate values written to controls
The bcm2835-audio driver makes no effort to validate the values it accepts
from userspace, causing it to accept invalid values:
# # PCM Playback Switch.0 Invalid boolean value 2
# not ok 5 write_invalid.Headphones.1
# # PCM Playback Volume.0 value -10240 less than minimum -10239
# # PCM Playback Volume.0 value 401 more than maximum 400
# not ok 12 write_invalid.Headphones.0
Add validation.
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20250415-staging-bcm2835-alsa-limit-v1-1-4ed816e9c0fc@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andy Shevchenko [Tue, 15 Apr 2025 09:10:19 +0000 (12:10 +0300)]
staging: rtl8723bs: Fix compilation errors for W=1 build
When building a kernel with Clang 19 the couple of warnings
become the errors (due to CONFIG_WERROR=y by default).
.../rtl8723bs/core/rtw_xmit.c:1939:13: error: variable 'drop_cnt' set but not used [-Werror,-Wunused-but-set-variable]
.../rtl8723bs/hal/hal_com.c:893:6: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]
Fix them accordingly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250415091019.545905-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erick Karanja [Fri, 11 Apr 2025 08:54:25 +0000 (11:54 +0300)]
staging: rtl8723bs: Use boolean false instead of integer 0
In the struct definition, adaptivity_flag is defined as type 'bool'.
This change replaces the integer literal 0 with the boolean
constant false to match the declared type. It ensures semantic
correctness, and aligns with kernel coding conventions
that prefer true/false over 1/0 for bool types.
found by coccinelle
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/20250411085425.44177-1-karanja99erick@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erick Karanja [Thu, 10 Apr 2025 07:11:51 +0000 (10:11 +0300)]
staging: rtl8723bs: Initialize variables at declaration in rtl8723b_hal_init.c
Make the code more concise and readable by integrating the initialization
directly into the variable declaration in cases where the initialization
is simple and doesn't depend on other variables or complex expressions.
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/4d52a207eadd99ad998214aa8eb059f725c94802.1744268316.git.karanja99erick@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erick Karanja [Thu, 10 Apr 2025 07:11:50 +0000 (10:11 +0300)]
staging: rtl8723bs: Initialize variables at declaration in rtl8723bs_xmit.c
Make the code more readable by moving trivial
initializations up with the declarations instead
of wasting a line on that.
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/0a2165d8135d2b4de6b9c05fdc56fe5d7408e7c8.1744268316.git.karanja99erick@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gabriel Shahrouzi [Sat, 5 Apr 2025 21:02:40 +0000 (17:02 -0400)]
staging: rtl8723bs: Remove trailing whitespace
Remove trailing whitespace to comply with kernel coding style.
Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com>
Link: https://lore.kernel.org/r/20250405210240.584821-1-gshahrouzi@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erick Karanja [Sat, 5 Apr 2025 11:26:05 +0000 (14:26 +0300)]
staging: rtl8723bs: use preferred comparison order
Refactor conditions check to follow the Linux kernel
coding style, which prefers placing the variable on the left side
of the comparison.
Reported by checkpatch:
WARNING: Comparisons should place the constant on the right side
of the test
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/3534b660142c78e800e369c31df091625e61f844.1743851473.git.karanja99erick@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erick Karanja [Sat, 5 Apr 2025 11:26:04 +0000 (14:26 +0300)]
staging: rtl8723bs: add spaces between ternary and binary operators
Fix spacing around binary arithmetic (`+`, `-`) and shift (`>>`) operators
to improve readability and adhere to the Linux kernel coding style.
Reported by checkpatch:
CHECK: spaces needed around 'operator'
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/ff993a669699e902909063aed03bb6183122c9a7.1743851473.git.karanja99erick@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abraham Samuel Adekunle [Sat, 5 Apr 2025 00:15:42 +0000 (00:15 +0000)]
staging: rtl8723bs: Place constants on right side of comparison
Modify comparisons to place constants on the right hand side of expression
thereby following Linux kernel coding conventions.
Found and transformed by Coccinelle.
Semantic patch used for matching and transformation:
@@
constant K;
expression E;
@@
- K == E
+ E == K
Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Link: https://lore.kernel.org/r/Z/B2LjtshZU6AX2f@ubuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bryant Boatright [Fri, 4 Apr 2025 13:35:11 +0000 (13:35 +0000)]
Staging: rtl8723bs: Fix unbalanced braces in conditional
Only one branch of conditional statement is a single statement thus both
branches should use braces to adhere to the Linux coding style.
Reported by checkpatch:
CHECK: Unbalanced braces around else statement
Signed-off-by: Bryant Boatright <bryant.boatright@proton.me>
Link: https://lore.kernel.org/r/Z-_gC8XOVoiXsC8i@ubuntu-desk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abraham Samuel Adekunle [Fri, 4 Apr 2025 08:20:39 +0000 (09:20 +0100)]
staging: rtl8723bs: modify struct field to use standard bool type
The struct sta_info field ieee8021x_blocked uses the uint values
0 and 1 to represent false and true values respectively.
Convert cases to use the bool type instead to ensure consistency
with other parts of the containing code where true or false have
been used.
This change causes the struct field to change size from a 32bit to
an 8bit. However, the change is safe to make because the sta_info
struct is not read from the hardware.
Reported by Coccinelle.
Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Link: https://lore.kernel.org/r/Z++WV1132FCULn+0@HP-650
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bartosz Golaszewski [Mon, 7 Apr 2025 07:14:52 +0000 (09:14 +0200)]
staging: greybus: use new GPIO line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Alex Elder <elder@riscstar.com>
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Link: https://lore.kernel.org/r/20250407-gpiochip-set-rv-greybus-v1-1-9d4f721db7ca@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thorsten Blum [Wed, 2 Apr 2025 11:57:54 +0000 (13:57 +0200)]
staging: greybus: Check for string truncation instead of NUL-termination
Commit
18f44de63f88 ("staging: greybus: change strncpy() to
strscpy_pad()") didn't remove the now unnecessary NUL-termination
checks. Unlike strncpy(), strscpy_pad() guarantees that the destination
buffer is NUL-terminated, making these checks obsolete. Remove them and
check for string truncation instead.
Compile-tested only.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://lore.kernel.org/r/20250402115755.1929043-1-thorsten.blum@linux.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erick Karanja [Wed, 26 Mar 2025 13:26:49 +0000 (16:26 +0300)]
staging: rtl8723bs: Rename variables
Rename the variable `mediaStatus` to `media_status` and variable
`lpsVal` to `lps_val` to adhere to Linux kernel coding
standards by using snake_case instead of CamelCase.
Fixes checkpatch.pl warning:
CHECK: Avoid CamelCase: <mediaStatus>
CHECK: Avoid CamelCase: <lpsVal>
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/20250326132649.22055-1-karanja99erick@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Abraham Samuel Adekunle [Wed, 26 Mar 2025 12:40:05 +0000 (13:40 +0100)]
staging: rtl8723bs: remove braces around single statements
The code contains braces around single statements in the if blocks
which are unnecessary according to the Linux kernel coding style.
Remove the braces to improve readability and maintain consistency.
Reported by checkpatch:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Link: https://lore.kernel.org/r/Z+P1pfLSKpiRtpaF@HP-650
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / linux-block.git / log