From: Eric Biggers <ebiggers@google.com>
Date: Fri, 15 Mar 2019 21:16:32 +0000 (-0700)
Subject: fscrypt: remove WARN_ON_ONCE() when decryption fails
X-Git-Tag: for-linus-20190516~59^2~8
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ff5d3a97075c65731a46453d36e75b9cf925e165;p=linux-block.git

fscrypt: remove WARN_ON_ONCE() when decryption fails

If decrypting a block fails, fscrypt did a WARN_ON_ONCE().  But WARN is
meant for kernel bugs, which this isn't; this could be hit by fuzzers
using fault injection, for example.  Also, there is already a proper
warning message logged in fscrypt_do_page_crypto(), so the WARN doesn't
add much.

Just remove the unnessary WARN.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c
index f5b69b9531f6..41dde4578f3b 100644
--- a/fs/crypto/bio.c
+++ b/fs/crypto/bio.c
@@ -37,12 +37,10 @@ static void __fscrypt_decrypt_bio(struct bio *bio, bool done)
 		int ret = fscrypt_decrypt_page(page->mapping->host, page,
 				PAGE_SIZE, 0, page->index);
 
-		if (ret) {
-			WARN_ON_ONCE(1);
+		if (ret)
 			SetPageError(page);
-		} else if (done) {
+		else if (done)
 			SetPageUptodate(page);
-		}
 		if (done)
 			unlock_page(page);
 	}