From: Phil Sutter <phil@nwl.cc>
Date: Fri, 20 Oct 2023 17:34:28 +0000 (+0200)
Subject: netfilter: nf_tables: Drop pointless memset in nf_tables_dump_obj
X-Git-Tag: io_uring-6.7-2023-11-10~40^2~37^2~11
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ff16111cc10c82ee065ffbd9fa8d6210394ff8c6;p=linux-block.git

netfilter: nf_tables: Drop pointless memset in nf_tables_dump_obj

The code does not make use of cb->args fields past the first one, no
need to zero them.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 03a306d15f43..fa216d1cfb74 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -7717,9 +7717,6 @@ static int nf_tables_dump_obj(struct sk_buff *skb, struct netlink_callback *cb)
 				goto cont;
 			if (idx < s_idx)
 				goto cont;
-			if (idx > s_idx)
-				memset(&cb->args[1], 0,
-				       sizeof(cb->args) - sizeof(cb->args[0]));
 			if (filter && filter->table &&
 			    strcmp(filter->table, table->name))
 				goto cont;