From: Josh Poimboeuf <jpoimboe@kernel.org>
Date: Fri, 14 Mar 2025 19:29:06 +0000 (-0700)
Subject: objtool: Upgrade "Linked object detected" warning to error
X-Git-Tag: io_uring-6.15-20250403~141^2~7
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=fdf5ff2934f4c5c6b483c906fea6e0288df36da2;p=linux-block.git

objtool: Upgrade "Linked object detected" warning to error

Force the user to fix their cmdline if they forget the '--link' option.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Brendan Jackman <jackmanb@google.com>
Link: https://lore.kernel.org/r/8380bbf3a0fa86e03fd63f60568ae06a48146bc1.1741975349.git.jpoimboe@kernel.org
---

diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c
index 36d81a455b01..79843512a51b 100644
--- a/tools/objtool/builtin-check.c
+++ b/tools/objtool/builtin-check.c
@@ -198,8 +198,8 @@ int objtool_run(int argc, const char **argv)
 		return 1;
 
 	if (!opts.link && has_multiple_files(file->elf)) {
-		ERROR("Linked object detected, forcing --link");
-		opts.link = true;
+		ERROR("Linked object requires --link");
+		goto err;
 	}
 
 	ret = check(file);