From: Tom St Denis Date: Tue, 6 Feb 2018 19:00:01 +0000 (-0500) Subject: drm/amd/powerplay: Zero out power data in AMDGPU_PP_SENSOR_GPU_POWER readout X-Git-Tag: for-linus-20180413~101^2~22^2~80 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=fda519fb5d7005d37e1675679a9f8dd0551b2d50;p=linux-block.git drm/amd/powerplay: Zero out power data in AMDGPU_PP_SENSOR_GPU_POWER readout Since 12 of the 16 bytes are not initialized with anything let's ensure they're sensibly zeroed out otherwise debugfs callers will read back garbage (because they assume debugfs wrote sensible data back...) Signed-off-by: Tom St Denis Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c index 5e3c63f8b62a..341fba5f7171 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c @@ -3889,7 +3889,9 @@ static int vega10_get_gpu_power(struct pp_hwmgr *hwmgr, return -EINVAL); vega10_read_arg_from_smc(hwmgr, &value); + /* power value is an integer */ + memset(query, 0, sizeof *query); query->average_gpu_power = value << 8; return 0;