From: Andres Urian Florez Date: Fri, 18 Apr 2025 22:47:49 +0000 (-0500) Subject: spi: offload: check for match callback when a trigger is being registered X-Git-Tag: v6.16-rc1~23^2~39 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=fcab1637bb115b3b7bbc600a6d019b785653f2d5;p=linux-block.git spi: offload: check for match callback when a trigger is being registered Make match a required callback when a new trigger is being registered, this allows that other functions like spi_offload_trigger_get() could safely invoke the callback when it is required In v2: - improve readability of the condition Signed-off-by: Andres Urian Florez Reviewed-by: David Lechner Link: https://patch.msgid.link/20250418224750.46219-1-andres.emb.sys@gmail.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-offload.c b/drivers/spi/spi-offload.c index 6bad042fe437..21a0f3a3a176 100644 --- a/drivers/spi/spi-offload.c +++ b/drivers/spi/spi-offload.c @@ -434,7 +434,7 @@ int devm_spi_offload_trigger_register(struct device *dev, { struct spi_offload_trigger *trigger; - if (!info->fwnode || !info->ops) + if (!info->fwnode || !info->ops || !info->ops->match) return -EINVAL; trigger = kzalloc(sizeof(*trigger), GFP_KERNEL);