From: Christian Brauner <brauner@kernel.org>
Date: Wed, 18 Jun 2025 20:53:50 +0000 (+0200)
Subject: pidfs: add some CONFIG_DEBUG_VFS asserts
X-Git-Tag: block-6.17-20250808~55^2~5^2
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=f9fac1f48c20a29f2c39c9a9b96d539ad1636824;p=linux-block.git

pidfs: add some CONFIG_DEBUG_VFS asserts

Allow to catch some obvious bugs.

Link: https://lore.kernel.org/20250618-work-pidfs-persistent-v2-16-98f3456fd552@kernel.org
Reviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/pidfs.c b/fs/pidfs.c
index bde19614ef8b..ba526fdd4c4d 100644
--- a/fs/pidfs.c
+++ b/fs/pidfs.c
@@ -809,6 +809,8 @@ static struct dentry *pidfs_fh_to_dentry(struct super_block *sb,
 	if (ret < 0)
 		return ERR_PTR(ret);
 
+	VFS_WARN_ON_ONCE(!pid->attr);
+
 	mntput(path.mnt);
 	return path.dentry;
 }
@@ -1038,6 +1040,8 @@ struct file *pidfs_alloc_file(struct pid *pid, unsigned int flags)
 	if (ret < 0)
 		return ERR_PTR(ret);
 
+	VFS_WARN_ON_ONCE(!pid->attr);
+
 	flags &= ~PIDFD_STALE;
 	flags |= O_RDWR;
 	pidfd_file = dentry_open(&path, flags, current_cred());