From: Tiezhu Yang <yangtiezhu@loongson.cn>
Date: Tue, 7 Jul 2020 02:12:45 +0000 (+0800)
Subject: irqchip/loongson-htpic: Remove redundant kfree operation
X-Git-Tag: block-5.9-2020-08-14~27^2^2~30
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=f90fafecf4880b9785da85feb9b3e6d85fbf2287;p=linux-2.6-block.git

irqchip/loongson-htpic: Remove redundant kfree operation

In the function htpic_of_init(), when kzalloc htpic fails, it should
return -ENOMEM directly, no need to execute "goto" to kfree.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1594087972-21715-2-git-send-email-yangtiezhu@loongson.cn
---

diff --git a/drivers/irqchip/irq-loongson-htpic.c b/drivers/irqchip/irq-loongson-htpic.c
index dd018c22ea83..63f72803c8c4 100644
--- a/drivers/irqchip/irq-loongson-htpic.c
+++ b/drivers/irqchip/irq-loongson-htpic.c
@@ -93,10 +93,8 @@ int __init htpic_of_init(struct device_node *node, struct device_node *parent)
 	}
 
 	htpic = kzalloc(sizeof(*htpic), GFP_KERNEL);
-	if (!htpic) {
-		err = -ENOMEM;
-		goto out_free;
-	}
+	if (!htpic)
+		return -ENOMEM;
 
 	htpic->base = of_iomap(node, 0);
 	if (!htpic->base) {