From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 6 Sep 2018 13:33:48 +0000 (+0300)
Subject: gpio: ep93xx: fix test for end of loop
X-Git-Tag: for-linus-20181026~73^2~71
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=f6d9af4770995d1f58be57139bce7974868231e8;p=linux-2.6-block.git

gpio: ep93xx: fix test for end of loop

The problem is that if port == ARRAY_SIZE() and "gc == &epg->gc[port]"
then that should be treated as invalid.

Fixes: fd935fc421e7 ("gpio: ep93xx: Do not pingpong irq numbers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index dd22ea19c3ed..71728d6e0bca 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -80,7 +80,7 @@ static int ep93xx_gpio_port(struct gpio_chip *gc)
 		port++;
 
 	/* This should not happen but is there as a last safeguard */
-	if (gc != &epg->gc[port]) {
+	if (port == ARRAY_SIZE(epg->gc)) {
 		pr_crit("can't find the GPIO port\n");
 		return 0;
 	}