From: weiping zhang Date: Thu, 23 Nov 2017 13:39:40 +0000 (+0800) Subject: blk-sysfs: remove NULL pointer checking in queue_wb_lat_store X-Git-Tag: v4.15-rc2~12^2~9 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=f680474345f1fd6329d1806d6358066fd3b07f02;p=linux-2.6-block.git blk-sysfs: remove NULL pointer checking in queue_wb_lat_store wbt_init doesn't set q->rq_wb to NULL, if wbt_init return 0, so check return value is enough, remove NULL checking. Signed-off-by: weiping zhang Signed-off-by: Jens Axboe --- diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index e54be402899d..870484eaed1f 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -450,12 +450,9 @@ static ssize_t queue_wb_lat_store(struct request_queue *q, const char *page, ret = wbt_init(q); if (ret) return ret; - - rwb = q->rq_wb; - if (!rwb) - return -EINVAL; } + rwb = q->rq_wb; if (val == -1) rwb->min_lat_nsec = wbt_default_latency_nsec(q); else if (val >= 0)