From: Jens Axboe <jens.axboe@oracle.com>
Date: Sat, 1 Mar 2008 14:25:24 +0000 (+0100)
Subject: Fix potential crash in terminate_threads()
X-Git-Tag: fio-1.20-rc1~29
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=f63f7f3bbc49c72ee06f351bf3a7312df32f9e3c;p=fio.git

Fix potential crash in terminate_threads()

td->io_ops can be NULL, if the thread is already gone. So copy the
pointer and check before dereferencing it.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---

diff --git a/fio.c b/fio.c
index 1594bf64..d345064d 100644
--- a/fio.c
+++ b/fio.c
@@ -82,8 +82,12 @@ static void terminate_threads(int group_id)
 			 */
 			if (td->runstate < TD_RUNNING)
 				kill(td->pid, SIGQUIT);
-			else if (td->io_ops->flags & FIO_SIGQUIT)
-				kill(td->pid, SIGQUIT);
+			else {
+				struct ioengine_ops *ops = td->io_ops;
+
+				if (ops && (ops->flags & FIO_SIGQUIT))
+					kill(td->pid, SIGQUIT);
+			}
 		}
 	}
 }