From: Bartosz Golaszewski Date: Fri, 15 Feb 2019 10:42:59 +0000 (+0100) Subject: nvmem: core: don't check the return value of notifier chain call X-Git-Tag: v5.1-rc1~147^2~51 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=f4853e1c321edb48af229ad5ac85076790d34968;p=linux-2.6-block.git nvmem: core: don't check the return value of notifier chain call blocking_notifier_call_chain() returns the value returned by the last registered callback. A positive return value doesn't indicate an error and an nvmem device should correctly register irrespective of any notifier callback failures. Drop the retval check. Fixes: bee1138bea15 ("nvmem: add a notifier chain") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski Acked-by: Srinivas Kandagatla Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 9dd07eae1f3e..f24008b66826 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -688,9 +688,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) if (rval) goto err_remove_cells; - rval = blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem); - if (rval) - goto err_remove_cells; + blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem); return nvmem;