From: Zhu Jun <zhujun2@cmss.chinamobile.com>
Date: Thu, 10 Oct 2024 01:41:26 +0000 (-0700)
Subject: samples/bpf: Fix a resource leak
X-Git-Tag: v6.13-rc1~136^2~58
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=f3ef53174b23246fe9bc2bbc2542f3a3856fa1e2;p=linux-block.git

samples/bpf: Fix a resource leak

The opened file should be closed in show_sockopts(), otherwise resource
leak will occur that this problem was discovered by reading code

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20241010014126.2573-1-zhujun2@cmss.chinamobile.com
---

diff --git a/samples/bpf/test_cgrp2_sock.c b/samples/bpf/test_cgrp2_sock.c
index a0811df888f4..8ca2a445ffa1 100644
--- a/samples/bpf/test_cgrp2_sock.c
+++ b/samples/bpf/test_cgrp2_sock.c
@@ -178,8 +178,10 @@ static int show_sockopts(int family)
 		return 1;
 	}
 
-	if (get_bind_to_device(sd, name, sizeof(name)) < 0)
+	if (get_bind_to_device(sd, name, sizeof(name)) < 0) {
+		close(sd);
 		return 1;
+	}
 
 	mark = get_somark(sd);
 	prio = get_priority(sd);