From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Mon, 25 Sep 2023 01:05:50 +0000 (-0400)
Subject: bcachefs: nocow locking: Fix lock leak
X-Git-Tag: io_uring-6.7-2023-11-10~119^2~26
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=efedfc2ece141389a9f522a298781cc929262701;p=linux-block.git

bcachefs: nocow locking: Fix lock leak

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/io_write.c b/fs/bcachefs/io_write.c
index d2a0de886c7a..6e4f85eb6ec8 100644
--- a/fs/bcachefs/io_write.c
+++ b/fs/bcachefs/io_write.c
@@ -1376,10 +1376,12 @@ err_get_ioref:
 	/* Fall back to COW path: */
 	goto out;
 err_bucket_stale:
-	while (--i >= 0)
+	while (i >= 0) {
 		bch2_bucket_nocow_unlock(&c->nocow_locks,
 					 buckets[i].b,
 					 BUCKET_NOCOW_LOCK_UPDATE);
+		--i;
+	}
 	for (i = 0; i < nr_buckets; i++)
 		percpu_ref_put(&bch_dev_bkey_exists(c, buckets[i].b.inode)->io_ref);