From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Sat, 7 Jan 2023 03:58:19 +0000 (-0500)
Subject: bcachefs: Delete a faulty assertion
X-Git-Tag: io_uring-6.7-2023-11-10~119^2~604
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ee94c413a7ef5f10a2768826b2e576981990c4b8;p=linux-block.git

bcachefs: Delete a faulty assertion

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c
index 326742e00159..398db0faa816 100644
--- a/fs/bcachefs/btree_iter.c
+++ b/fs/bcachefs/btree_iter.c
@@ -1011,12 +1011,11 @@ retry_all:
 	}
 
 	/*
-	 * BTREE_ITER_NEED_RELOCK is ok here - if we called bch2_trans_unlock()
-	 * and relock(), relock() won't relock since path->should_be_locked
-	 * isn't set yet, which is all fine
+	 * We used to assert that all paths had been traversed here
+	 * (path->uptodate < BTREE_ITER_NEED_TRAVERSE); however, since
+	 * path->Should_be_locked is not set yet, we we might have unlocked and
+	 * then failed to relock a path - that's fine.
 	 */
-	trans_for_each_path(trans, path)
-		BUG_ON(path->uptodate >= BTREE_ITER_NEED_TRAVERSE);
 err:
 	bch2_btree_cache_cannibalize_unlock(c);