From: Arnd Bergmann Date: Mon, 15 Jul 2024 06:02:30 +0000 (+0200) Subject: platform: cznic: turris-omnia-mcu: fix Kconfig dependencies X-Git-Tag: io_uring-6.11-20240722~97^2~4 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ed46f1f7731d2cd77d623c0f895df9e23c0bffb6;p=linux-2.6-block.git platform: cznic: turris-omnia-mcu: fix Kconfig dependencies The newly added driver causes a Kconfig warning: WARNING: unmet direct dependencies detected for RTC_CLASS Depends on [n]: !S390 [=y] Selected by [m]: - TURRIS_OMNIA_MCU [=m] && CZNIC_PLATFORMS [=y] && (MACH_ARMADA_38X || COMPILE_TEST [=y]) && I2C [=m] && OF [=y] && WATCHDOG [=y] The problem here is that it selects entire subsystems, which normal device drivers should not do. Changes all of these to 'depends on' instead. Fixes: dfa556e45ae9e ("platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs") Fixes: 90e700fd12b61 ("platform: cznic: turris-omnia-mcu: Add support for poweroff and wakeup") Fixes: ab89fb5fb92c7 ("platform: cznic: turris-omnia-mcu: Add support for MCU watchdog") Fixes: 41bb142a40289 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG") Reported-by: Nathan Chancellor Signed-off-by: Arnd Bergmann --- diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig index 2a5235cf6844..cb0d4d686d8a 100644 --- a/drivers/platform/cznic/Kconfig +++ b/drivers/platform/cznic/Kconfig @@ -18,11 +18,11 @@ config TURRIS_OMNIA_MCU depends on I2C depends on OF depends on WATCHDOG - select GPIOLIB + depends on GPIOLIB + depends on HW_RANDOM + depends on RTC_CLASS + depends on WATCHDOG_CORE select GPIOLIB_IRQCHIP - select HW_RANDOM - select RTC_CLASS - select WATCHDOG_CORE help Say Y here to add support for the features implemented by the microcontroller on the CZ.NIC's Turris Omnia SOHO router.