From: Christophe JAILLET Date: Tue, 24 Nov 2020 15:59:18 +0000 (+0200) Subject: ath10k: Fix an error handling path X-Git-Tag: io_uring-5.11-2020-12-23~79^2~122^2^2~4 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ed3573bc3943c27d2d8e405a242f87ed14572ca1;p=linux-block.git ath10k: Fix an error handling path If 'ath10k_usb_create()' fails, we should release some resources and report an error instead of silently continuing. Fixes: 4db66499df91 ("ath10k: add initial USB support") Signed-off-by: Christophe JAILLET Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20201122170342.1346011-1-christophe.jaillet@wanadoo.fr --- diff --git a/drivers/net/wireless/ath/ath10k/usb.c b/drivers/net/wireless/ath/ath10k/usb.c index 05a620ff6fe2..0b47c3a09794 100644 --- a/drivers/net/wireless/ath/ath10k/usb.c +++ b/drivers/net/wireless/ath/ath10k/usb.c @@ -997,6 +997,8 @@ static int ath10k_usb_probe(struct usb_interface *interface, ar_usb = ath10k_usb_priv(ar); ret = ath10k_usb_create(ar, interface); + if (ret) + goto err; ar_usb->ar = ar; ar->dev_id = product_id;