From: Lorenzo Bianconi Date: Thu, 18 Nov 2021 10:50:27 +0000 (+0100) Subject: mt76: mt7921: fix possible NULL pointer dereference in mt7921_mac_write_txwi X-Git-Tag: block-5.17-2022-01-21~91^2~134^2~20^2~50 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ec2ebc1c5a5ce49538fa78108c53eaf722eee908;p=linux-2.6-block.git mt76: mt7921: fix possible NULL pointer dereference in mt7921_mac_write_txwi Fix a possible NULL pointer deference issue in mt7921_mac_write_txwi routine if vif is NULL. Fixes: 33920b2bf0483 ("mt76: add support for setting mcast rate") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau --- diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index 9bbbc0d89694..401f91c1657a 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -981,7 +981,7 @@ void mt7921_mac_write_txwi(struct mt7921_dev *dev, __le32 *txwi, mt7921_mac_write_txwi_80211(dev, txwi, skb, key); if (txwi[2] & cpu_to_le32(MT_TXD2_FIX_RATE)) { - int rateidx = ffs(vif->bss_conf.basic_rates) - 1; + int rateidx = vif ? ffs(vif->bss_conf.basic_rates) - 1 : 0; u16 rate, mode; /* hardware won't add HTC for mgmt/ctrl frame */