From: Thierry Reding <treding@nvidia.com>
Date: Thu, 20 Dec 2018 17:19:56 +0000 (+0100)
Subject: mailbox: mtk-cmdq: Remove needless devm_kfree() calls
X-Git-Tag: for-linus-20190104~9^2~13
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ec1c674f0ae3905cd540ab2f30d9c4265981d7b4;p=linux-block.git

mailbox: mtk-cmdq: Remove needless devm_kfree() calls

Memory allocated through device-managed functions doesn't need to be
explicitly freed, so these calls can be removed.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index d9c3ec3667a8..22811784dc7d 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -339,14 +339,6 @@ static int cmdq_remove(struct platform_device *pdev)
 
 	clk_unprepare(cmdq->clock);
 
-	if (cmdq->mbox.chans)
-		devm_kfree(&pdev->dev, cmdq->mbox.chans);
-
-	if (cmdq->thread)
-		devm_kfree(&pdev->dev, cmdq->thread);
-
-	devm_kfree(&pdev->dev, cmdq);
-
 	return 0;
 }